Task non recusive calls

[catrielmuller]

Context

Refactors the recursive recursivelyMakeClineRequests method to use an iterative stack-based approach to prevent potential stack overflow issues in deep conversation loops.

Implementation

• Introduces a new makeRequest method that implements the same logic as the recursive version using an explicit stack
• Replaces the recursive call with the new non-recursive implementation
• Uses a state machine approach with stack frames to manage the request flow

[changeset-bot]

⚠️ No Changeset found

Latest commit: b39fc0d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[Copilot]

Pull Request Overview

Refactors the recursive recursivelyMakeClineRequests method to use an iterative stack-based approach to prevent potential stack overflow issues in deep conversation loops.

• Introduces a new makeRequest method that implements the same logic as the recursive version using an explicit stack
• Replaces the recursive call with the new non-recursive implementation
• Uses a state machine approach with stack frames to manage the request flow

[Copilot]

The comment contains a grammatical error. It should be 'use manual iterator instead of for...of' (with proper spacing around the ellipsis).

Suggested change

	// kilocode change: use manual iterator instead of for ... of
	// kilocode change: use manual iterator instead of for...of

[Copilot]

[nitpick] The stack-based approach continues the loop with continue after pushing a new frame, but the comment suggests this replaces a recursive call. Consider adding a comment explaining why continue is used here instead of a more explicit control flow to make the intent clearer.

[Copilot]

The stack-based approach processes frames sequentially but could potentially build up a large stack for deeply nested conversations. Consider adding a maximum stack depth check to prevent excessive memory usage.

Suggested change

	// Before pushing a new frame, check stack depth
	const pushFrame = (newFrame: StackFrame) => {
	if (stack.length >= MAX_STACK_DEPTH) {
	throw new Error(`[KiloCode#request] Maximum stack depth (${MAX_STACK_DEPTH}) exceeded in task ${this.taskId}.${this.instanceId}. Possible infinite or excessively deep conversation nesting.`);
	}
	stack.push(newFrame);
	};