fix(ci): cap stalled unit jobs at 45 minutes#10854
Merged
Merged
Conversation
imanolmzd-svg
approved these changes
Jun 3, 2026
catrielmuller
approved these changes
Jun 3, 2026
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 file)
Reviewed by claude-4.6-sonnet-20260217 · 155,016 tokens Review guidance: REVIEW.md from base branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLI unit subprocess leaks can leave the
unitmatrix job running until GitHub's default six-hour timeout, consuming runner capacity and blocking the required test check.Cap the unit job at 45 minutes. Healthy runs finish well below that ceiling, while a leaked subprocess now fails within a bounded window instead of retaining a runner for hours.
This is intentionally a containment measure, not a test-runtime optimization. Follow-up work should harden process-tree cancellation in the CLI test runner and profile the Windows TUI plugin lifecycle slowdown.