Skip to content

refactor(vscode): extract shared diff review UI#10853

Merged
marius-kilocode merged 2 commits into
mainfrom
refactor/shared-diff-review-ui
Jun 3, 2026
Merged

refactor(vscode): extract shared diff review UI#10853
marius-kilocode merged 2 commits into
mainfrom
refactor/shared-diff-review-ui

Conversation

@marius-kilocode

Copy link
Copy Markdown
Collaborator

The reusable diff review UI still lived under Agent Manager even though the standalone Changes tab and virtual diff viewer depend on the same rendering, file-tree, Markdown, and inline-review behavior. That ownership boundary made shared behavior look Agent Manager-specific and made cross-surface fixes harder to reason about.

Move the shared diff review cluster into webview-ui/diff-viewer/ and update Agent Manager, sidebar Changes, virtual diffs, Storybook, and architecture tests to import through that boundary. Agent Manager-specific orchestration and its sidebar panel remain in webview-ui/agent-manager/. Existing stylesheet imports stay attached to the shared fullscreen component so every bundle continues receiving the required styles.

Closes #10848

@kilo-code-bot

kilo-code-bot Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (14 files)
  • packages/kilo-vscode/tests/unit/agent-manager-arch.test.ts
  • packages/kilo-vscode/tests/unit/agent-manager-diff-state.test.ts
  • packages/kilo-vscode/tests/unit/diff-viewer-css-arch.test.ts
  • packages/kilo-vscode/tests/unit/file-tree.test.ts
  • packages/kilo-vscode/tests/unit/markdown-annotation-layer.test.ts
  • packages/kilo-vscode/tests/unit/review-comments.test.ts
  • packages/kilo-vscode/webview-ui/agent-manager/AgentManagerApp.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/ApplyDialog.tsx
  • packages/kilo-vscode/webview-ui/agent-manager/DiffPanel.tsx
  • packages/kilo-vscode/webview-ui/diff-viewer/DiffViewerApp.tsx
  • packages/kilo-vscode/webview-ui/diff-viewer/FullScreenDiffView.tsx (renamed)
  • packages/kilo-vscode/webview-ui/diff-virtual/DiffVirtualApp.tsx
  • packages/kilo-vscode/webview-ui/src/stories/agent-manager.stories.tsx
  • 10 renamed files (pure moves, no content changes)

This is a clean mechanical refactor. All import paths in tests, Agent Manager, diff-viewer, diff-virtual, and Storybook have been updated to point at the new webview-ui/diff-viewer/ location. No stale imports remain in the old agent-manager/ path. The architecture test for CSS imports (diff-viewer-css-arch.test.ts) correctly reflects the updated relative path ../agent-manager/agent-manager.css from the new location. The CSS invariant is preserved.

Fix these issues in Kilo Cloud


Reviewed by claude-4.6-sonnet-20260217 · 503,376 tokens

Review guidance: REVIEW.md from base branch main

@marius-kilocode marius-kilocode enabled auto-merge June 3, 2026 13:10
@marius-kilocode marius-kilocode merged commit ec51a8e into main Jun 3, 2026
19 of 20 checks passed
@marius-kilocode marius-kilocode deleted the refactor/shared-diff-review-ui branch June 3, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move shared diff review UI out of Agent Manager

2 participants