refactor(vscode): extract shared diff review UI#10853
Merged
Merged
Conversation
imanolmzd-svg
approved these changes
Jun 3, 2026
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (14 files)
This is a clean mechanical refactor. All import paths in tests, Agent Manager, diff-viewer, diff-virtual, and Storybook have been updated to point at the new Fix these issues in Kilo Cloud Reviewed by claude-4.6-sonnet-20260217 · 503,376 tokens Review guidance: REVIEW.md from base branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reusable diff review UI still lived under Agent Manager even though the standalone Changes tab and virtual diff viewer depend on the same rendering, file-tree, Markdown, and inline-review behavior. That ownership boundary made shared behavior look Agent Manager-specific and made cross-surface fixes harder to reason about.
Move the shared diff review cluster into
webview-ui/diff-viewer/and update Agent Manager, sidebar Changes, virtual diffs, Storybook, and architecture tests to import through that boundary. Agent Manager-specific orchestration and its sidebar panel remain inwebview-ui/agent-manager/. Existing stylesheet imports stay attached to the shared fullscreen component so every bundle continues receiving the required styles.Closes #10848