fix(vscode): preserve inline review drafts across diff refreshes#10846
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge The implementation is clean and correct. Key design observations:
Files Reviewed (6 files)
Reviewed by claude-4.6-sonnet-20260217 · 666,067 tokens Review guidance: REVIEW.md from base branch |
Contributor
|
Does this change cover the diff view that opens from sidebar chat as well? |
Collaborator
Author
|
The core fix applies to the sidebar-chat Changes view as well |
1 task
imanolmzd-svg
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inline review comments could disappear while they were still being written because diff refreshes replace disposable annotation DOM nodes. The same loss could happen when moving between Agent Manager sidebar and fullscreen review surfaces.
Preserve unfinished drafts and edits in lightweight in-memory composer metadata outside the textarea DOM. Diff renderers restore that metadata whenever annotations are rebuilt, Agent Manager review surfaces share the active composer during view transitions, and context changes clear transient state so drafts cannot leak between worktrees. Typing remains non-reactive, avoiding diff rerenders on every keystroke.