Skip to content

Revert "fix: suppress false incomplete response warnings"#10826

Merged
catrielmuller merged 1 commit into
mainfrom
revert-10800-troubled-hawk
Jun 2, 2026
Merged

Revert "fix: suppress false incomplete response warnings"#10826
catrielmuller merged 1 commit into
mainfrom
revert-10800-troubled-hawk

Conversation

@catrielmuller

Copy link
Copy Markdown
Contributor

Reverts #10800

@catrielmuller catrielmuller enabled auto-merge June 2, 2026 16:16
@kilo-code-bot

kilo-code-bot Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

This is a clean mechanical revert of #10800. The diff is consistent with the intent: all code, tests, and changeset files added by the original PR are removed, and the reverted shared files (packages/opencode/src/session/processor.ts, packages/opencode/src/session/prompt.ts) are back to their pre-#10800 state with the appropriate kilocode_change markers removed.

A few behavioral consequences of the revert worth noting (not blocking):

  • Snapshot false-positive warnings may reappear: terminal() in session-outcome.ts no longer skips snapshot-only assistant turns, so a snapshot initialization turn appearing as the last message will trigger an "unexpected" outcome banner again.
  • Oversized payload after pruning: packages/opencode/src/session/prompt.ts now only logs a warning when nextSize > REQUEST_PRUNE_BYTES instead of aborting with an error. Oversized payloads will be sent to the provider and may fail at the API level.
  • Empty finish: "other" responses: The guardEmptyResponse retry logic is gone. Empty provider responses will be treated as successful completions.

These are the deliberate regressions being accepted by reverting #10800.

snapshotProgress and SNAPSHOT_PROGRESS_TEXT remain in session-utils.ts and are still used by AssistantMessage.tsx for part labeling — no dead code introduced.

Files Reviewed (9 files)
  • .changeset/calm-snapshot-warnings.md - deleted (correct)
  • .changeset/tidy-responses-finish.md - deleted (correct)
  • packages/kilo-vscode/tests/unit/session-outcome.test.ts - snapshot-related tests removed
  • packages/kilo-vscode/webview-ui/src/components/shared/TurnOutcome.tsx - parts prop removed
  • packages/kilo-vscode/webview-ui/src/context/session-outcome.ts - simplified terminal() function
  • packages/kilo-vscode/webview-ui/src/context/session-utils.ts - snapshotOnlyAssistant and tokenCount removed
  • packages/opencode/src/kilocode/session/processor.ts - emptyResponseError, guardEmptyResponse, parse, EMPTY_RESPONSE_MESSAGE removed
  • packages/opencode/src/kilocode/session/prompt.ts - payloadOverflowError, rejectPayloadOverflow, PAYLOAD_OVERFLOW_MESSAGE removed
  • packages/opencode/src/kilocode/worktree-family.ts - comment wording tweak only
  • packages/opencode/src/session/processor.ts - parse reverted, guardEmptyResponse call removed
  • packages/opencode/src/session/prompt.ts - rejectPayloadOverflow call replaced with log.warn
  • packages/opencode/test/kilocode/session/processor-effect.test.ts - deleted
  • packages/opencode/test/kilocode/session/prompt.test.ts - deleted

Reviewed by claude-4.6-sonnet-20260217 · 461,842 tokens

Review guidance: REVIEW.md from base branch main

@catrielmuller catrielmuller merged commit bff5546 into main Jun 2, 2026
19 checks passed
@catrielmuller catrielmuller deleted the revert-10800-troubled-hawk branch June 2, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants