Skip to content

fix(cli): allow clearing agent variant overrides#10792

Merged
marius-kilocode merged 2 commits into
mainfrom
bejewled-grain
Jun 1, 2026
Merged

fix(cli): allow clearing agent variant overrides#10792
marius-kilocode merged 2 commits into
mainfrom
bejewled-grain

Conversation

@marius-kilocode

Copy link
Copy Markdown
Collaborator

The Agent Behaviour model and variant override dropdowns added in #10505 introduced a settings-save regression. Selecting Not set for an agent model correctly sends model: null and variant: null so both overrides are removed, but the CLI config schema accepted the model deletion sentinel while rejecting the variant deletion sentinel. VS Code therefore could not save the reset to the default model.

Allow nullable agent variants in config patches so model and variant overrides can be cleared consistently. Keep the deletion behavior scoped to config persistence, including JSONC updates that preserve unrelated agent settings and existing comments.

@marius-kilocode marius-kilocode enabled auto-merge June 1, 2026 13:57
@kilo-code-bot

kilo-code-bot Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (3 files)
  • .changeset/calm-agent-variant-clear.md
  • packages/opencode/src/config/agent.ts
  • packages/opencode/test/kilocode/config/config.test.ts

Reviewed by claude-4.6-sonnet-20260217 · 307,567 tokens

Review guidance: REVIEW.md from base branch main

@marius-kilocode marius-kilocode merged commit 4faf255 into main Jun 1, 2026
18 checks passed
@marius-kilocode marius-kilocode deleted the bejewled-grain branch June 1, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants