feat(cli): support XLSX text extraction in read tool#10740
Merged
Conversation
imanolmzd-svg
approved these changes
May 29, 2026
Contributor
Code Review SummaryStatus: 3 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Other Observations (not in diff)
Files Reviewed (5 files)
Fix these issues in Kilo Cloud Reviewed by claude-4.6-sonnet-20260217 · 1,208,954 tokens Review guidance: REVIEW.md from base branch |
…raction # Conflicts: # packages/opencode/src/tool/read.ts
This was referenced May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spreadsheet files are still classified as binary by the
readtool, so agents cannot inspect workbook contents without an external conversion step.This adds
.xlsxextraction for explicitreadcalls only. Visible worksheets are surfaced as labelled tab-separated text with readable formulas, formatted values, dates, hyperlinks, and errors. Hidden sheets are omitted, workbook inputs above 50 MB are rejected before parsing, worksheet extraction is bounded, and the existing read output limits continue to apply. Native PDF and image attachment behavior, along with rejection of unsupported binary spreadsheet formats, stays unchanged.With notebook and DOCX reads now present in
main, format selection is consolidated behind a Kilo-owned read extraction router rather than adding another format-specific control-flow branch to the sharedreadtool. The existing notebook and DOCX extractors continue to supply their behavior through the same narrow hook.The parser uses official SheetJS CE
0.20.3from its pinned distribution tarball because the public npm registry release is outdated and affected by known vulnerabilities. It adds no transitive runtime dependencies. Compared with currentmain, the current-platform compiled CLI artifact increases from105,737,122bytes to106,678,306bytes, an increase of941,184bytes (approximately0.90 MiB).