Skip to content

refactor(cli): make notebook read routing explicit#10739

Merged
marius-kilocode merged 1 commit into
mainfrom
fix/read-notebook-guard
May 29, 2026
Merged

refactor(cli): make notebook read routing explicit#10739
marius-kilocode merged 1 commit into
mainfrom
fix/read-notebook-guard

Conversation

@marius-kilocode

Copy link
Copy Markdown
Collaborator

Follow-up to #10733. Notebook reads take a format-specific extraction path, but the shared read hook currently has to infer that choice from an optional extraction result.

Expose notebook file matching on the notebook domain and guard the extraction route explicitly in the read hook. This keeps notebook parsing and content rendering isolated in Kilo-owned code while making the shared control flow immediately readable. Runtime behavior is unchanged.

@marius-kilocode marius-kilocode enabled auto-merge May 29, 2026 14:42
@kilo-code-bot

kilo-code-bot Bot commented May 29, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)
  • packages/opencode/src/kilocode/tool/notebook.ts
  • packages/opencode/src/tool/read.ts

Reviewed by claude-4.6-sonnet-20260217 · 300,108 tokens

Review guidance: REVIEW.md from base branch main

@marius-kilocode marius-kilocode merged commit 2c7eeaa into main May 29, 2026
17 checks passed
@marius-kilocode marius-kilocode deleted the fix/read-notebook-guard branch May 29, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants