fix(vscode): show shell command description in permission approval prompt#10692
Merged
Conversation
…ompt When a shell command has a descriptive title (the parameter provided by the AI), include it in the permission approval dialog so users can identify what the command will do, not just see the raw command string.
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
Contributor
Author
Code Review SummaryStatus: 2 Suggestions (carried forward) | Recommendation: Merge (suggestions are non-blocking) Overview
Issue Details (click to expand)SUGGESTION (carried forward from initial review)
Latest commit (671340a) — no new issues
Files Reviewed (8 files + 4 baseline images)
Fix these issues in Kilo Cloud Reviewed by claude-4.6-sonnet-20260217 · 131,450 tokens Review guidance: REVIEW.md from base branch |
Contributor
|
Validated it works: |
Contributor
|
Made it better 
|
marius-kilocode
approved these changes
Jun 2, 2026
Collaborator
Would it not make sense to move the scrollbar to the very right? @lambertjosh
|
Contributor
The scrollbar is the full height of the command prompt panel itself. that's just the size of the displayed portion vs. the full buffer. Here it is in light mode: I can remove the grey background of the prompt, but I think it actually provides nicer contrast IMO. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When a shell command includes a descriptive title (the
descriptionparameter the AI provides — e.g. "Install project dependencies" or "Run all tests"), that description is now shown in the permission/approval dialog alongside the raw command.Previously, the approval dialog only showed the raw shell command string. The description was only ever used for the tool card in chat (after execution). Users had no way to quickly identify what a command was intended to do before approving it.
Why
The
descriptionfield already exists in the shell tool's parameter schema and is shown in the chat message after execution. Including it in the pre-execution approval dialog gives users better context when deciding whether to approve a command.Changes
packages/opencode/src/tool/shell.ts: Theaskhelper now accepts an optionaldescriptionparameter and includes it in themetadataobject passed toctx.ask(). The call site passesparams.descriptionthrough.packages/kilo-vscode/webview-ui/src/types/messages/permissions.ts: Addeddescription?: stringto theargsfield ofPermissionRequestso the type reflects the new metadata field.packages/kilo-vscode/webview-ui/src/components/chat/PermissionDock.tsx: Readsargs.descriptionand renders it as apermission-hintelement above the raw command block when present.Built for Joshua Lambert by Kilo for Slack