Skip to content

fix(vscode): make session history accessible to screen readers#10686

Merged
marius-kilocode merged 5 commits into
mainfrom
fix-a11y-history-10672
May 29, 2026
Merged

fix(vscode): make session history accessible to screen readers#10686
marius-kilocode merged 5 commits into
mainfrom
fix-a11y-history-10672

Conversation

@marius-kilocode

Copy link
Copy Markdown
Collaborator

Session history embeds rename and delete actions within the button used to open a session, which makes focus order and announcements unreliable for keyboard and screen-reader users. Local and Cloud history switching also needs explicit selected-state semantics.

This changes history rows to expose session opening, renaming, and deletion as separate named controls, announces the active and current session during search-based navigation, and represents history sources as keyboard-navigable tabs with associated panels. The shared list primitive remains unchanged, keeping the remediation scoped to the VS Code history workflow.

Fixes #10672

@marius-kilocode marius-kilocode enabled auto-merge May 28, 2026 15:13
@kilo-code-bot

kilo-code-bot Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

The incremental change since the previous review (commit e9bbd4d) is a single CI-generated commit:

  • 6731c1d — Updates the visual regression baseline PNG (history-sessionlist/sources-chromium-linux.png) via Git LFS. This is a Linux CI-generated artifact; per review policy, visual regression snapshots are excluded from manual review.

All previous review findings remain valid (no issues found). The accessibility remediation and i18n additions continue to be well-implemented.

Files Reviewed (10 files)
  • .changeset/clear-history-navigation.md
  • packages/kilo-docs/public/img/screenshot-tests/kilo-vscode/visual-regression/history-sessionlist/sources-chromium-linux.png (CI-generated baseline — not reviewed)
  • packages/kilo-vscode/tests/history-accessibility.spec.ts
  • packages/kilo-vscode/webview-ui/src/components/history/CloudSessionList.tsx
  • packages/kilo-vscode/webview-ui/src/components/history/HistoryView.tsx
  • packages/kilo-vscode/webview-ui/src/components/history/SessionList.tsx
  • packages/kilo-vscode/webview-ui/src/stories/history.stories.tsx
  • packages/kilo-vscode/webview-ui/src/styles/history.css
  • packages/kilo-vscode/webview-ui/src/i18n/*.ts (18 locale files)
  • packages/kilo-vscode/webview-ui/src/i18n/it.ts (Italian locale fix)

Reviewed by claude-sonnet-4.6 · 149,312 tokens

Review guidance: REVIEW.md from base branch main

@kilo-code-bot kilo-code-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regression-focused subagent review: no confirmed behavior or accessibility regression found in the session-history changes.

I specifically checked rename/delete activation isolation and Enter-to-save behavior. In this patch the action buttons and rename editor replace the list-item button as siblings inside the row wrapper, so they no longer bubble through the session-selection button; dropping the old nested-control stop behavior is consistent with that structural fix. The remaining gap is non-blocking coverage: add assertions that rename/delete activation and rename save/cancel do not select or open a session, plus focus restoration after the delete dialog.

@marius-kilocode marius-kilocode force-pushed the fix-a11y-history-10672 branch from 99e6007 to e748140 Compare May 29, 2026 07:29
@marius-kilocode marius-kilocode force-pushed the fix-a11y-history-10672 branch from 101fac2 to e9bbd4d Compare May 29, 2026 11:07
@marius-kilocode marius-kilocode merged commit 1fd2b9c into main May 29, 2026
20 checks passed
@marius-kilocode marius-kilocode deleted the fix-a11y-history-10672 branch May 29, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Correct session history keyboard and screen-reader semantics

2 participants