fix(vscode): make session history accessible to screen readers#10686
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge The incremental change since the previous review (commit
All previous review findings remain valid (no issues found). The accessibility remediation and i18n additions continue to be well-implemented. Files Reviewed (10 files)
Reviewed by claude-sonnet-4.6 · 149,312 tokens Review guidance: REVIEW.md from base branch |
There was a problem hiding this comment.
Regression-focused subagent review: no confirmed behavior or accessibility regression found in the session-history changes.
I specifically checked rename/delete activation isolation and Enter-to-save behavior. In this patch the action buttons and rename editor replace the list-item button as siblings inside the row wrapper, so they no longer bubble through the session-selection button; dropping the old nested-control stop behavior is consistent with that structural fix. The remaining gap is non-blocking coverage: add assertions that rename/delete activation and rename save/cancel do not select or open a session, plus focus restoration after the delete dialog.
99e6007 to
e748140
Compare
101fac2 to
e9bbd4d
Compare
Session history embeds rename and delete actions within the button used to open a session, which makes focus order and announcements unreliable for keyboard and screen-reader users. Local and Cloud history switching also needs explicit selected-state semantics.
This changes history rows to expose session opening, renaming, and deletion as separate named controls, announces the active and current session during search-based navigation, and represents history sources as keyboard-navigable tabs with associated panels. The shared list primitive remains unchanged, keeping the remediation scoped to the VS Code history workflow.
Fixes #10672