Skip to content

test(vscode): enforce scoped webview accessibility coverage#10680

Merged
marius-kilocode merged 2 commits into
mainfrom
test-vscode-a11y-coverage-10673
May 29, 2026
Merged

test(vscode): enforce scoped webview accessibility coverage#10680
marius-kilocode merged 2 commits into
mainfrom
test-vscode-a11y-coverage-10673

Conversation

@marius-kilocode

Copy link
Copy Markdown
Collaborator

VS Code webview workflows have screenshot coverage, but it cannot catch regressions in accessible names, semantic relationships, or keyboard operation. The isolated development launch path also forces accessibility support off, leaving accessibility repairs without a durable gate or practical assistive-technology validation path.

This change adds a scoped Playwright and axe accessibility ratchet for stable webview story states, with focused keyboard coverage and a Storybook inspection panel. The scope is intentionally incremental so existing accessibility backlog does not block unrelated work, while repaired workflows can be enrolled as they land. It also adds an accessible extension launch mode that enables assistive-technology validation without changing the default development behavior.

Closes #10673

@marius-kilocode marius-kilocode enabled auto-merge May 28, 2026 14:49
Comment thread packages/kilo-vscode/script/launch.ts Outdated
Comment thread packages/kilo-vscode/tests/accessibility.spec.ts Outdated
@kilo-code-bot

kilo-code-bot Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Overview

All 2 issues from the previous review have been resolved in the follow-up commit (ffad65db):

Previous Issue Resolution
WARNING (accessibility.spec.ts): No initial focus anchor before Tab — flaky test risk Fixed: new reach() helper loops up to 10 Tabs to locate the target before asserting focus
SUGGESTION (launch.ts): Redundant if (enabled) assignment outside ternary Fixed: enabled override consolidated into the keep=true spread, eliminating the dead write
Files Reviewed (3 files changed in follow-up)
  • .github/workflows/visual-regression.yml# kilocode_change marker added to two lines; no logic change
  • packages/kilo-vscode/script/launch.ts — previous redundant assignment removed; logic is now correct for both keep paths
  • packages/kilo-vscode/tests/accessibility.spec.tsreach() helper added and replaces the single-Tab assumption; previous warning resolved

Fix these issues in Kilo Cloud


Reviewed by claude-sonnet-4.6 · 279,143 tokens

Review guidance: REVIEW.md from base branch main

@kilo-code-bot kilo-code-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regression-focused subagent review: no blocking regression found in this PR. The scoped axe/keyboard test is wired into the webview visual workflow and avoids making existing untriaged stories block this change.

Non-blocking follow-up: the current ratchet allowlist does not yet include the repaired chat-decision, model-selector, prompt-suggestion, or history workflows addressed by the companion accessibility PRs. Keep the focused interaction specs in those PRs and add their stable fixtures to this axe ratchet as they land so future semantic regressions are caught centrally.

@marius-kilocode marius-kilocode merged commit bc2e794 into main May 29, 2026
18 checks passed
@marius-kilocode marius-kilocode deleted the test-vscode-a11y-coverage-10673 branch May 29, 2026 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add accessibility regression coverage for VS Code webview workflows

2 participants