feat: remove semantic indexing experimental gate#10668
Merged
Merged
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge The change is coherent and correctly implemented end-to-end. Key observations:
New commit ( Files Reviewed (31 files)
Reviewed by claude-4.6-sonnet-20260217 · 226,580 tokens Review guidance: REVIEW.md from base branch |
chrarnoldus
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Semantic indexing is hidden behind
experimental.semantic_indexingeven though indexing already has explicit global and project opt-in controls. This adds a redundant configuration step and prevents users from accessing indexing settings until a separate flag is enabled.Expose semantic indexing settings and CLI controls whenever the indexing plugin is available, and retire the experimental configuration key. Indexing still remains disabled until it is explicitly enabled globally or for a project, and existing configurations containing the retired flag continue to load without changing indexing enablement.
semantic_searchremains gated by an enabled and initialized index.