fix(cli): toggle export dialog checkboxes on mouse click#10306
Merged
catrielmuller merged 1 commit intoJun 2, 2026
Conversation
aaef4a8 to
ccf2422
Compare
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge OverviewPR #10306 is clean. Both files have been reviewed:
No bugs, no security issues, no style violations introduced. Files Reviewed (2 files)
Reviewed by claude-4.6-sonnet-20260217 · 416,449 tokens Review guidance: REVIEW.md from base branch |
ccf2422 to
c9e1e82
Compare
The export options dialog checkbox rows only set visual focus on mouse click but don't toggle the checkbox state. Update onMouseUp handlers to both set focus and toggle the corresponding boolean value.
7f3cbb3 to
aca8aeb
Compare
catrielmuller
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
In the TUI export options dialog, clicking on checkbox rows only highlights/focuses them but does not toggle the checkbox value. Users must use keyboard navigation (Tab + Space) to toggle options, which is inconsistent with expected mouse interaction patterns.
Closes #10305
Implementation
Updated the 4 checkbox row
onMouseUphandlers indialog-export-options.tsxto both set visual focus (active) AND toggle the corresponding boolean value (thinking,toolDetails,assistantMetadata,openWithoutSaving). Keyboard shortcuts (Tab for navigation, Space for toggle, Return for confirm) remain unaffected.Screenshots
Before
before.mp4
After
after.mp4
How To Test
bun devand open a sessionGet in Touch
Discord: @IamCoder18