Skip to content

fix(cli): toggle export dialog checkboxes on mouse click#10306

Merged
catrielmuller merged 1 commit into
Kilo-Org:mainfrom
IamCoder18:fix/export-dialog-checkbox-toggle
Jun 2, 2026
Merged

fix(cli): toggle export dialog checkboxes on mouse click#10306
catrielmuller merged 1 commit into
Kilo-Org:mainfrom
IamCoder18:fix/export-dialog-checkbox-toggle

Conversation

@IamCoder18

Copy link
Copy Markdown
Contributor

Context

In the TUI export options dialog, clicking on checkbox rows only highlights/focuses them but does not toggle the checkbox value. Users must use keyboard navigation (Tab + Space) to toggle options, which is inconsistent with expected mouse interaction patterns.

Closes #10305

Implementation

Updated the 4 checkbox row onMouseUp handlers in dialog-export-options.tsx to both set visual focus (active) AND toggle the corresponding boolean value (thinking, toolDetails, assistantMetadata, openWithoutSaving). Keyboard shortcuts (Tab for navigation, Space for toggle, Return for confirm) remain unaffected.

Screenshots

Before

before.mp4

After

after.mp4

How To Test

  • Run bun dev and open a session
  • Trigger "Export session transcript" command
  • Click on any checkbox option with mouse. It should now toggle on click
  • Verify keyboard navigation (Tab/Space) still works correctly

Get in Touch

Discord: @IamCoder18

@IamCoder18 IamCoder18 force-pushed the fix/export-dialog-checkbox-toggle branch from aaef4a8 to ccf2422 Compare May 15, 2026 22:55
@kilo-code-bot

kilo-code-bot Bot commented May 15, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Overview

PR #10306 is clean. Both files have been reviewed:

  • packages/opencode/src/cli/cmd/tui/ui/dialog-export-options.tsx — The 4 onMouseUp handlers each now call both setStore("active", ...) and setStore(<field>, !store.<field>), correctly toggling the checkbox value on mouse click while preserving keyboard navigation. Logic is sound, no regressions.
  • .changeset/export-dialog-checkbox-click.md — Targets @kilocode/cli at patch level with a concise user-facing description. Valid and complete.

No bugs, no security issues, no style violations introduced.

Files Reviewed (2 files)
  • packages/opencode/src/cli/cmd/tui/ui/dialog-export-options.tsx
  • .changeset/export-dialog-checkbox-click.md

Reviewed by claude-4.6-sonnet-20260217 · 416,449 tokens

Review guidance: REVIEW.md from base branch main

The export options dialog checkbox rows only set visual focus on mouse click but don't toggle the checkbox state. Update onMouseUp handlers to both set focus and toggle the corresponding boolean value.
@IamCoder18 IamCoder18 force-pushed the fix/export-dialog-checkbox-toggle branch from 7f3cbb3 to aca8aeb Compare May 20, 2026 02:30
@johnnyeric johnnyeric requested a review from catrielmuller May 21, 2026 12:03
@catrielmuller catrielmuller merged commit 35f30ad into Kilo-Org:main Jun 2, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Export dialog checkboxes don't toggle on mouse click

2 participants