Fix support of float atomics in threadgroup memory.#2611
Closed
duburcqa wants to merge 1 commit into
Closed
Conversation
|
|
duburcqa
changed the title
HansKristian-Work
requested changes
Apr 20, 2026
| expected_type = to_signed_basetype(type.width); | ||
|
|
||
| // Metal does not support float atomics in threadgroup memory. When the | ||
| // atomic result type is integer but the pointee type is float (CAS-based |
Contributor
There was a problem hiding this comment.
Does SPIRV-Cross do that CAS emulation? I'm not aware of that. I'm really missing a test case here. Just uploading some failing .spv is fine. I can commit that on the side if it's a hassle to run the test suite. I'm not convinced this would work as-is.
Author
There was a problem hiding this comment.
Thank you for taking the time to review my PR. Actually I moved CAS emulation in Quadrants itself to avoid having to modify SPIRV-Cross, I'm just replacing the original float atomics and the correct instruction to never generate code that would need this feature, so I don't need any changes in SPIRV-Cross.
For reference: Genesis-Embodied-AI/quadrants@79ec049
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.