Small improvements to searchspaces and simulation mode#251
Small improvements to searchspaces and simulation mode#251benvanwerkhoven merged 7 commits intomasterfrom
Conversation
| # "ngangs", | ||
| # "nworkers", | ||
| # "vlength", |
There was a problem hiding this comment.
Why are these lines commented?
There was a problem hiding this comment.
These block size names were added for OpenACC. The default block sizes were added automatically if the block size is not defined by the user, causing issues with these parameters outside of OpenACC. I spoke with @isazi about this, if I understood correctly these are no longer needed, hence commented pending removal.
| if isinstance(restrict, Constraint): | ||
| restrict = convert_constraint_restriction(restrict) | ||
| if not restrict(list(selected_params.values())): | ||
| valid = False | ||
| break | ||
| else: | ||
| if not restrict(**selected_params): | ||
| valid = False | ||
| break |
There was a problem hiding this comment.
It seems our automated linting system 'SonarCloud' isn't too happy about this level of nesting control flow. Maybe we can break things up into smaller chunks?
There was a problem hiding this comment.
I've refactored this into two separate functions, SonarCloud is happy again.
fjwillemsen
changed the title
|
|
Thanks! |
2 participants
This pull request solves various small issues regarding search spaces and simulation mode:
block_sizesdoes not exceedmax_threadswas not added back to the restrictions, which were later rechecked for each configuration ifcheck_restrictionsis enabled, causing a discrepancy.check_restrictionsfunction.MinProdconstraint was added to the conversion function for backwards compatibility.