Skip to content

Fix accessibility regression in loading spinners #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Keboo merged 2 commits into from
May 30, 2026
Merged

Fix accessibility regression in loading spinners #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f67096
Use MSTest v4 throw assertions
Keboo May 30, 2026
72616f4
Fix progress indicator accessibility labels
Keboo May 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions SimplyBudgetSharedTests/Data/ExpenseCategoryItemTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ public void SetIgnoreBudget_WithNull_Throws()
{
var item = new ExpenseCategoryItem();

var ex = Assert.ThrowsException<ArgumentNullException>(() => item.IgnoreBudget = null);
var ex = Assert.ThrowsExactly<ArgumentNullException>(() => item.IgnoreBudget = null);
Assert.AreEqual("value", ex.ParamName);
}

Expand All @@ -75,7 +75,7 @@ public void SetIgnoreBudget_True_Throws()
{
var item = new ExpenseCategoryItem();

var ex = Assert.ThrowsException<ArgumentNullException>(() => item.IgnoreBudget = null);
var ex = Assert.ThrowsExactly<ArgumentNullException>(() => item.IgnoreBudget = null);
Assert.AreEqual("value", ex.ParamName);
}

Expand Down
2 changes: 1 addition & 1 deletion SimplyBudgetWeb.Web/src/components/AddTransactionDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ export default function AddTransactionDialog({ open, onClose, categories, onSucc
<DialogActions>
<Button onClick={handleClose}>Cancel</Button>
<Button variant="contained" onClick={handleSubmit} disabled={submitting}>
{submitting ? <CircularProgress size={20} /> : 'Save'}
{submitting ? <CircularProgress size={20} aria-label="Saving transaction" /> : 'Save'}
</Button>
</DialogActions>
</Dialog>
Expand Down
2 changes: 1 addition & 1 deletion SimplyBudgetWeb.Web/src/pages/Accounts.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ export default function Accounts() {
</Box>

{loading ? (
<Box sx={{ display: 'flex', justifyContent: 'center', p: 4 }}><CircularProgress /></Box>
<Box sx={{ display: 'flex', justifyContent: 'center', p: 4 }}><CircularProgress aria-label="Loading accounts" /></Box>
) : (
<List>
{accounts.map(account => (
Expand Down
2 changes: 1 addition & 1 deletion SimplyBudgetWeb.Web/src/pages/Budget.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ export default function Budget() {

{loading ? (
<Box sx={{ display: 'flex', justifyContent: 'center', p: 4 }}>
<CircularProgress />
<CircularProgress aria-label="Loading budget" />
</Box>
) : (
<Box>
Expand Down
2 changes: 1 addition & 1 deletion SimplyBudgetWeb.Web/src/pages/History.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ export default function History() {
</Paper>

{loading ? (
<Box sx={{ display: 'flex', justifyContent: 'center', p: 4 }}><CircularProgress /></Box>
<Box sx={{ display: 'flex', justifyContent: 'center', p: 4 }}><CircularProgress aria-label="Loading history" /></Box>
) : (
<List>
{items.length === 0 && (
Expand Down
4 changes: 2 additions & 2 deletions SimplyBudgetWeb.Web/src/pages/Import.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ export default function Import() {
sx={{ mb: 2 }}
/>
<Button variant="contained" onClick={handleParse} disabled={loading || !csvText.trim()}>
{loading ? <CircularProgress size={20} /> : 'Parse'}
{loading ? <CircularProgress size={20} aria-label="Parsing import data" /> : 'Parse'}
</Button>
</Paper>

Expand Down Expand Up @@ -133,7 +133,7 @@ export default function Import() {
</Table>
</Paper>
<Button variant="contained" onClick={handleImport} disabled={submitting}>
{submitting ? <CircularProgress size={20} /> : 'Save Import'}
{submitting ? <CircularProgress size={20} aria-label="Saving import" /> : 'Save Import'}
</Button>
</>
)}
Expand Down
2 changes: 1 addition & 1 deletion SimplyBudgetWeb.Web/src/pages/Settings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ export default function Settings() {
</Box>

{loading ? (
<Box sx={{ display: 'flex', justifyContent: 'center', p: 4 }}><CircularProgress /></Box>
<Box sx={{ display: 'flex', justifyContent: 'center', p: 4 }}><CircularProgress aria-label="Loading import rules" /></Box>
) : (
<List>
{rules.length === 0 && <ListItem><ListItemText primary="No rules defined." /></ListItem>}
Expand Down
Loading