[Editor GUI] Show warnings when the vessel cannot be integrated#2852
Open
dlesbre wants to merge 8 commits into
Open
[Editor GUI] Show warnings when the vessel cannot be integrated#2852dlesbre wants to merge 8 commits into
dlesbre wants to merge 8 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The editor KCT GUI had a single warning for human-rated vessels in non human-rated LC. This PR expands that to all vessel checks (mass limits, size limits, resources, clamp in hangar), and makes the label yellow. To avoid issues with long resource lists, the warnings list is cut after 5 elements:
I've spliced into the VesselProject.MeetsFacilityRequirements to avoid recoding the checks. However, since the GUI is quite narrow, I wanted shorter error messages to avoid line breaks. So I added an extra shortReasons parameter, which returns alternate strings.
Full disclaimer: while I have fairly extensive programming experience, this is my first time with C#. Let me know if what I'm missing some good coding practices.