feat: switch to WASM-only executor#841
Merged
Merged
Conversation
ntn-x2
force-pushed
the
aa/wasm-only-executor
branch
from
91fe3cb to
7f6ebdf
Compare
ntn-x2
force-pushed
the
aa/wasm-only-executor
branch
from
7f6ebdf to
bf58267
Compare
Ad96el
reviewed
Jan 10, 2025
Ad96el
left a comment
Ad96el
left a comment
Contributor
There was a problem hiding this comment.
One small comment. I compared the implementation with the parachain templates. Seems fine from my side.
I haven’t tested the client yet, but if you think it’s worth it, I can attempt to reproduce the checks in your list.
Contributor
Author
|
@Ad96el the checklist was more for me to remind what to do, and I'm quite sure it would also work for you. So perhaps you can approve, and we will try to catch anything else during our release process. |
Ad96el
approved these changes
Jan 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for the
CheckMetadataextension to work properly. Fixes https://github.com/KILTprotocol/ticket/issues/3744. Changes "inspired" from this PR: paritytech/cumulus#1054.How to test
We can re-test this and other related scenarios during our deployment to staging. I already included the step in the next release ticket.
Checklist