Documentation update with better examples of objects reading and editing#350
Open
isHarryh wants to merge 3 commits intoK0lb3:masterfrom
Open
Documentation update with better examples of objects reading and editing#350isHarryh wants to merge 3 commits intoK0lb3:masterfrom
isHarryh wants to merge 3 commits intoK0lb3:masterfrom
Conversation
Owner
|
Thanks, I will try to come around combining your changes with the ones I recently made. |
K0lb3
reviewed
Feb 19, 2026
| # note that the best way to pass a file to UnityPy is | ||
| # using with-statement to ensure the file can be properly closed | ||
| with open("path/to/your/file", "rb") as f: | ||
| env = UnityPy.load(f) |
Owner
There was a problem hiding this comment.
This could actually cause issues for SerializedFiles, as they aren't read into memory due to no decompression.
Something like
f = open(fp, "rb")
env = UnityPy.load(f)
# use the environment
f.close()would be better
Owner
|
Welp, sorry, I somehow totally forgot about your PR -.-' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the README file:
with and open()to manage file handle). We already have some issues like Can't move files after opening them #349 related to the new file-locking feature introduced in 1.23.0. The best way to avoid these issues is to improve our documentation.obj.save(instance)should beinstance.save().closes #349
closes #332