Repository navigation
fix(terminal): repair stale GPU glyphs after scrolling - #790
Merged
Merged
Conversation
Scrolling colored output exposes stale cell coordinates and texture-version collisions in the pinned WebGL addon. Coalesce a texture rebind and viewport refresh after atlas changes without evicting shared glyphs or touching terminal state. Keep the version-specific bridge isolated and fail back to DOM if its shape changes. Refs #789
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The newly enabled GPU path exposes corruption in pinned xterm WebGL 0.19.0 under colored CLI output and scrollback. Atlas merges during rendering leave stale cell coordinates; per-page texture-version collisions can also keep the wrong GPU texture bound. Refresh alone is insufficient.
Change
Refs #789
Upstream: xtermjs/xterm.js#5883 and xtermjs/xterm.js#6038
Verification
Limits
The exact user screenshot still requires post-deployment confirmation, so this references rather than closes #789. The fix repairs stale frames on the next scheduled frame; it is not an upstream synchronous merge-loop backport. GPU smoke coverage is opt-in because ordinary headless CI cannot guarantee a usable graphics context. The broader React/performance refactor remains isolated in its separate worktree. Not merged; awaiting review and CI.