Skip to content

fix(workspace): render orphaned ghost fallback entries - #7

Merged
Juliusolsson05 merged 1 commit into
mainfrom
fix/ghost-orphan-fallback
Apr 24, 2026
Merged

Juliusolsson05 merged 1 commit into
mainfrom
fix/ghost-orphan-fallback

Conversation

@Juliusolsson05

Copy link
Copy Markdown
Owner

Summary

  • mark stale unsuperseded ghosts as orphaned and persist that state
  • render only orphaned, non-current, unsuperseded ghosts in the main feed
  • add a focused ghost fallback regression test and npm script

Validation

  • npm run test:ghost-fallback
  • npm run test:work-context
  • npm run build
  • git diff --check

@Juliusolsson05
Juliusolsson05 merged commit 55bbdb1 into main Apr 24, 2026
@Juliusolsson05
Juliusolsson05 deleted the fix/ghost-orphan-fallback branch April 24, 2026 16:55
Juliusolsson05 added a commit that referenced this pull request May 11, 2026
…irks docs (#71)

* feat(paste): event-driven submit + per-paste debug dump + headless quirks docs

Bundles three coordinated changes addressing the long-standing
"first Enter on a multi-line paste does nothing; second Enter
submits" intermittent in Claude composers.

Track A — documentation in claude-code-headless submodule:
  - Thick WHY comment above HeadlessTerminal.scheduleFlush explaining
    that the 'screen' event silently stops firing under Claude's
    synchronized-output protocol (pendingWrites stays > 0 with
    @xterm/headless under sync-out pressure). Consumers needing
    correctness should poll snapshotPlain() directly.
  - Stronger warning on the activity-event debouncer that the
    SPINNER_VERB_RE walk produces false negatives during
    tool-result rows and transient headers, and the 'activity'
    event must NOT be used as a binary "did this submit?" verdict.
    The paste-submit harness lost 2/10 iterations on a spurious
    spinner read before we figured this out.

Track B — per-paste debug dump:
  Mirror of the dictation-debug subsystem from PR #68. Every Enter
  in a Claude composer mints a pasteId and emits
  RENDER/IPC/PTY/SCREEN/OUTCOME events into
  <userData>/paste-debug/<pasteId>.paste.jsonl. Renderer and main
  both write into the same file keyed by pasteId; payloads are
  sha8-fingerprinted so the IPC and PTY events can be paired across
  the renderer↔main boundary. 100 ms batched, 14-day prune.

  This is the diagnostic that will finally answer "why does the
  PTY-isolated harness pass 10/10 with the production 125 ms timer
  but the user still hits the bug live?" Hypotheses include IPC
  variance shrinking the effective gap, a double-fire on Enter
  where a second \r races the first paste's payload, or a React
  state mutation between paste and submit — the dump shape lets us
  pick the right one from a real failing session.

Track C — event-driven paste-submit:
  Replaces the unconditional 125 ms wall-clock wait between
  bracketed paste and \r with a poll for Claude's `[Pasted text #N]`
  placeholder. The PTY-isolated harness shows event-driven is
  10/10 reliable with an average wait of ~58 ms vs. the timer's
  125 ms unconditional floor. Falls back to the timer after a 2 s
  safety bound if the placeholder never materializes (future-Claude
  rename insurance). Gated by settings.eventDrivenPasteSubmit,
  default ON. Setting also exposed in Settings → Workspace.

Submodule bump:
  packages/claude-code-headless → feat/paste-submit-headless-fix
  e59235a — adds ClaudeCodeHeadless.awaitPastePlaceholder and the
  two doc comments above. Will need to be merged to submodule main
  before this cc-shell PR can merge.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* chore: bump claude-code-headless to main (PR #7 merged)

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant