Repository navigation
feat(ci): run typecheck and all test projects on every PR - #556
Merged
Merged
Conversation
Until now nothing ran on pull requests - release.yml is manual-dispatch only, so every merge decision rested on whoever remembered that neither electron-vite build nor vitest type-checks. One macos job mirrors the proven validation half of release.yml's build-app job (typecheck, workflow-mcp tests, unit/integration/renderer). Packaging, dual-arch verification, and npm audit deliberately stay release-only; there is no lint job because the repo has no linter by choice. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
One lean workflow,
.github/workflows/ci.yml: a single macOS job running the repo's real gates on every PR and push to main —npm run typecheck(the only type gate in the repo), workflow-mcp package tests, and the unit / integration / renderer Vitest projects.Why
Nothing ran on PRs before this. release.yml is workflow_dispatch-only, so merges relied entirely on local discipline in a repo whose best-documented trap is that build and tests do not type-check. The #533 merge-then-revert and PR #526 arriving with zero checks are the failure mode this closes.
Deliberately excluded
npm audit— advisory drift fails PRs that changed nothing; stays in release.yml.Proof
This PR is the first run of the workflow itself — the checks below are the evidence.
🤖 Generated with Claude Code