Repository navigation
Fix: reader view uses the pane's actual provider (opencode negation sweep) - #412
Merged
Merged
Conversation
ReaderBody chose the extractor provider with `(meta?.kind === 'codex') ? 'codex' : 'claude'`, collapsing opencode (a registered provider since phase 7) to Claude. Latent today — opencode has no PTY/screen, so extractAssistantInProgress returns '' for it regardless — but the negation would silently mis-extract the moment opencode grows screen text or the extractor changes. Use the pane's real kind (guarded by isAgentProviderKind; terminal/unknown fall back to DEFAULT_PROVIDER), completing the sweep of binary claude/codex negations that mishandle opencode. Verified: tsc node+web 0; build ok; 170/170 tests. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This was referenced Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last of the binary
? 'codex' : 'claude'negations that mishandle OpenCode.ReaderBodychose the screen-extractor provider with(meta?.kind === 'codex') ? 'codex' : 'claude', collapsing opencode to Claude.Latent today (opencode has no PTY/screen, so
extractAssistantInProgressreturns''for it regardless), but the negation would silently mis-extract the moment opencode grows screen text or the extractor changes. Now uses the pane's real kind (guarded byisAgentProviderKind; terminal/unknown →DEFAULT_PROVIDER).Completes the sweep started by #410 (switch guard) and #411 (palette resume) — no binary claude/codex negations that could mishandle opencode remain in active paths.
Verification
tscnode+web → 0 · build ✓ ·npm test→ 170/170🤖 Generated with Claude Code