Repository navigation
Providers phase 2c-2: identity descriptor — registry-derived glyphs, labels, resume commands, spawn lists - #400
Merged
Juliusolsson05 merged 1 commit intoJul 6, 2026
Conversation
…labels, resume commands, spawn lists Adds glyph / shortLabel / spawnDescription / resumeCommand to RendererProviderCapabilities (implemented as CLAUDE_IDENTITY / CODEX_IDENTITY descriptors in providers/*/renderer/identity.ts) and replaces every hand-written identity ternary with a registry lookup: - providerGlyph (sessionDisplay.ts): ⏺/›/$ ternary → registry for agent kinds, terminal keeps its literal. - providerLabel ×2 (formatWorktreeDump short labels, TileLeaf/labels long display names with the documented missing-kind→DEFAULT_PROVIDER back-compat). - buildProviderResumeCommand: the claude `--resume` flag vs codex `resume` subcommand ternary → registry resumeCommand; quoting and the `cd` prefix stay caller policy. - "waiting for Codex…/Claude Code…" strings (renderModel, Feed) → registry display name. - PathPickerModal provider toggle and NewAgentPlacementOverlay KIND_OPTIONS: hand-written provider lists → derived from AGENT_PROVIDER_KINDS + registry metadata. This closes #394 §4.6 — a registered provider previously compiled but was UNSPAWNABLE from the UI because the spawn surfaces enumerated providers by hand. - Opportunistic: PathPickerModal's useState('claude') / reset default → DEFAULT_PROVIDER (a phase-1 pattern the perl sweep missed because it wasn't a `?? 'claude'`). Verified: tsc clean on both projects, electron-vite build clean, vitest 170/170. Part of #394 (phase 2c; feeds the phase-4 command rewrite, which consumes the same descriptors). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This was referenced Jul 6, 2026
Juliusolsson05
deleted the
refactor/providers-phase2c2-identity-descriptor
branch
July 7, 2026 21:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #394 (phase 2c). Follows #399.
What
RendererProviderCapabilitiesgains an identity descriptor (glyph,shortLabel,spawnDescription,resumeCommand) implemented per provider inproviders/*/renderer/identity.ts. Every hand-written identity surface becomes a registry lookup:providerGlyph/providerLabel×2 /buildProviderResumeCommand/ the "waiting for …" feed stringsKIND_OPTIONSnow derive fromAGENT_PROVIDER_KINDS+ registry — closing Plug-and-play provider architecture: modularize and standardize all provider implementations #394 §4.6, where a registered provider compiled but was unspawnable because spawn UIs enumerated providers by hand.This is the data layer the phase-4 command rewrite consumes (palette entries, "Split with X" commands, badges).
Verification
tsc --noEmitclean on both projects;electron-vite buildclean;vitest170/170.🤖 Generated with Claude Code