Repository navigation
Integration batch O (#1439, #1451) - #1461
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
node-pty 1.1.0's pty_posix_spawn leaks one /dev/ptmx per spawn (low_fds[0] is never closed), so a long-running app exhausts kern.tty.ptmx_max and every spawn fails. Port upstream microsoft/node-pty#882 as a sha256-guarded source patch run from postinstall before electron-rebuild; pin node-pty to 1.1.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…root management (#1339) usage_read returns the same sanitized snapshot as the Usage screen and ac_usage_read (one shared readUsageSnapshotForTools, no force, the 30 s cache). Configurable on every provider, off by default, not gated. The tool-boundary test reads a recorded ac_usage_read answer that the manager supplies (testing/fixtures/usage, pending). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…#1339) The manager's raw answer from the owner's machine (read in full: plan names, percentages, labels; no credentials). Pins that the recorded Grok error row reaches the agent as an error, not zero usage. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
# Conflicts: # src/main/index.ts # src/mcp/runtime/BuiltInMcpHttpHost.ts
… symlink (#1439 review a, b) a: the unit test asserts the generated 'if (low_fds[i] != -1)' and final 'if (spawn_err != 0)' text, so an inversion fails CI even with the recorded hash updated (Linux CI never runs the macOS fd test). b: the CLI entry compares realpaths; through a symlinked path it used to exit 0 without patching. Pinned by running the real script via a symlink. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… real classifier (#1439 review c) The comment and plan claimed nothing in the app matched on 'posix_spawnp failed'. src/main/ipc/session.ts classifySpawnFailure keys the posix-spawnp signature on it. Both now say so, and session.test.ts pins that the patched node-pty messages ('posix_spawnp failed: <call>: <strerror>') keep that signature. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
review a) An agent holding only Orchestration could mint the off-by-default usage domain for a child and read the quota back; usage now joins the parent-held- only set. sanitizeUsageError passed any message naming auth.json verbatim, including an fs error's absolute credential path; only Agent Code's own fixed auth.json messages keep their words, the rest is one curated sentence. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…iew a) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…q132, security) sanitizeUsageError passed messages by prefix/substring (Keychain, '<Provider> auth.json ...', 'Grok login expired'), so a prefix-shaped error with a path or token tail passed whole to the usage MCP domain. It now keeps only the exact sentences Agent Code throws; everything else is fixed text. Pinned at the sanitizer, the real Usage reader's error row and the real usage_read tool. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…tructions with the domain (#1451 review c) - usageSnapshotForTools.test.ts drives the real readUsageSnapshotForTools over the real Usage service (only the provider reads replaced, with the recorded rows): the Grok error stays an error row, and two default reads hit the providers once. Dropping error rows (6 red) or a force default (1 red) fail. - main passes the reader itself, not a lambda, so no unpinned wrapper can add force. - usageTools.test.ts asserts the instructions ship WITH the domain (dropping them: 1 red) and types the fixture rows as recorded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
Juliusolsson05
force-pushed
the
integration/batch-2026-09-27-o
branch
from
September 27, 2026 19:16
35949e7 to
1681e68
Compare
fix(pty): stop leaking one /dev/ptmx per macOS spawn (node-pty 1.1.0 low_fds[0])
feat(mcp): an optional Usage domain so agents can read quota without root management
Owner
Author
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integration batch O (owner-approved merge mode, owner-requested history form). The branch was built from origin/main 1681e68 (batch N). Each member PR was retargeted to this branch and merged through GitHub, so history shows "Merge pull request #N from " for each member.
Both members had GATE PASS (--member). Merged after green exact-head CI and a recorded non-member gate PASS (see comments).
🤖 Generated with Claude Code