Repository navigation
fix(codex): a resumed rollout that starts with compacted shows its retained prompts - #1410
Closed
Juliusolsson05 wants to merge 2 commits into
Closed
Juliusolsson05 wants to merge 2 commits into
Juliusolsson05 wants to merge 2 commits into
Conversation
…tained prompts (#1393) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
Status (W1): held and recommended to park. Reviews a and b are both FIX-BEFORE-MERGE, and the findings go beyond a patch:
After narrowing to non-fork files, the benefit is 19 July-era CLI rollouts. I recommend closing this PR and keeping #1393 open with these findings as the design input: a loader-provided file-head fact, a fork policy, and a user-authored filter. The manager decides. |
….ts, both exec de-dup and file-head retained prompts kept) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
Closed by B6 (manager, owner proxy) during the owner's PR freeze: 7 review findings are still open and it can't converge under the freeze. Nothing is deleted. The branch stays on origin and the PR can be reopened. The linked issue stays open with this PR's findings as its starting point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1393. Depends on #1386, which maps
compactedat all. The PR is based on that branch, so this diff shows only the #1393 change. It cannot join a batch before #1386 merges.Plan:
docs/plans/2026-09-27-codex-resumed-compaction-history.md.Problem
compactedline. Its retained user prompts are the only copy of that earlier conversation in the file.replacement_history, because elsewhere it duplicates prompts: 33,443 of 37,724 retained user items have an earlier match.Change
The stateful
createCodexTranscriptEntryMapperknows when it is at a file's head: asession_metaline with no conversation record since.session_metamarks the head. 0 of 2,579 local rollouts have asession_metaafter a conversation record.compactedline also maps its retained user prompts (mapCodexRetainedUserHistory), before the boundary.compactionitem are skipped.session_metafirst, so they never map retained prompts.Tests (
resumedHeadCompaction.test.ts, the real mapper)The fixture is the real head of a 0.145.0 rollout that starts with
compacted. Text is redacted to the same length, except the two bootstrap marker prefixes the filter recognises. I checked every leaf.session_metagives only the boundary.Verification
npx tsc -bclean.src/providers,src/renderer/src/rendering,features/feedandworkspace: 339 files, 2,519 tests.Not done
The retained prompts render as ordinary user rows; there is no "retained" marker. That styling is a separate UX call.
🤖 Generated with Claude Code