Skip to content

fix(remote): put every phone chrome band on the 12px feed gutter - #1023

Merged
Juliusolsson05 merged 2 commits into
mainfrom
fix/remote-phone-gutter
Sep 19, 2026
Merged

Juliusolsson05 merged 2 commits into
mainfrom
fix/remote-phone-gutter

Conversation

@Juliusolsson05

Copy link
Copy Markdown
Owner

Problem

The owner reported that margin and padding on mobile are broken. In the phone (remote-client) shell, the v1 chrome bands (.topbar, .section-label, .session-row, .terminal, .working) used a 14px horizontal gutter. The mounted desktop feed (--feed-gutter: 12px), the composer and the v2 chrome all use 12px, so adjacent bands sat 2px apart.

This work was finished by an earlier agent session and left uncommitted in the main checkout. This PR moves it onto a branch, unchanged (release-readiness thread T3).

Implemented

  • All five bands use 12px, and a "gutter contract" header comment explains the single scale.
  • gutterContract.test.ts asserts the stylesheet text, which is the file the phone loads. jsdom never evaluates this CSS, so computed-style assertions could not see it; nordTheme.test.ts uses the same approach.

Verification

  • Fail-first against main's stylesheet: .topbar, .section-label, .session-row and .terminal fail.
  • With the fix, the remote-client unit suite passes 33/33.
  • Not checked visually (the app is not launched here). Worth a look on a phone after release.

🤖 Generated with Claude Code

Juliusolsson05 and others added 2 commits September 18, 2026 23:37
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The v1 phone chrome was born with a 14px gutter while the mounted desktop
feed, the composer and the v2 chrome use 12px. The 2px shear between
adjacent bands was the owner's 'mobile padding is broken' report. Five
bands move to 12px, and a stylesheet-text contract test pins the single
gutter. It fails on 4 bands against main.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@Juliusolsson05
Juliusolsson05 merged commit 2af693d into main Sep 19, 2026
2 checks passed
@Juliusolsson05
Juliusolsson05 deleted the fix/remote-phone-gutter branch September 19, 2026 06:51
Juliusolsson05 added a commit that referenced this pull request Sep 19, 2026
Pick up #1022 (goal-loop input freeze), #1023, #933 (tmux inventory) and
#1012. One conflict, in useKeybinds' onBlur: keep #1022's
dismissGoalLoop() and drop `pendingTiledResizeIndex`, which #992 deleted
along with tiled resize. #1022's overlay gate and rebind-safe dismiss
chord merged intact.

Verified: tsc -b clean. goal-loop + tile-tree + tldr renderer 175/175;
tmux + storage + remote-client unit 112/112. That includes #933's
real-workspace recovery test running against #992's model.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant