bug(ui): Enter on a focused Cancel applies the change in Agent View Mode, Reorder Tabs and Pin Agents #867

Expected

In every dialog, a focused footer button owns its own Enter: Tab to Cancel + Enter cancels, Tab to Done + Enter does what Done does. This is the rule src/renderer/src/components/ui/dialog-actions.tsx documents, now exported as focusedControlOwnsEnter (#860).

Actual

Three list-style dialogs handle Enter on DialogContent themselves, call preventDefault (which cancels the focused button's native click), and run the list's own action instead — the same bug #862 fixed in Switch Provider:

Reproduction

For each dialog: open it, change the selection with the arrow keys, press Tab until Cancel is focused, press Enter.

Impact

Keyboard users who cancel get the change they were abandoning applied (view mode, tab order, pins).

Suggested fix

Use the pattern #860 established for New Agent In and Switch Provider:

• guard the Enter branch with focusedControlOwnsEnter(event.target) (exported from components/ui/dialog-actions.tsx) — this also covers Reorder Tabs' non-DialogFooter footer, since the check is on the focused control, not the footer slot;
• keep list rows out of the tab order (tabIndex={-1}) where rows are buttons, so a Tab-focused row cannot diverge from the arrow-driven highlight (Space would click it regardless of any Enter handling);
• one regression test per dialog (focused Cancel + Enter must not act; fireEvent.keyDown returning true proves the native click was not prevented).

Notes

Found by the second review round of #860 (an audit of all 36 DialogContent consumers for list-level Enter handlers). The others are safe: their Enter is scoped to an input/scroller that excludes the footer, they have no footer buttons, or they trap Tab. Related: #862.