Skip to content

chore(deps): take vscode-languageserver-protocol 3.18 with vscode-jsonrpc 9 #1203

Open

Description

@Juliusolsson05

Split out of #987.

vscode-languageserver-protocol 3.18.x changes Diagnostic.message to string | MarkupContent, and it depends on vscode-jsonrpc 9, while the app pins vscode-jsonrpc ^8.2.1 (package.json). That would put two copies side by side, and Dependabot never proposes the jsonrpc major.

Change

Acceptance

  • npm ls vscode-jsonrpc shows one copy.
  • The LSP tests pass.
  • Diagnostics whose message is Markdown render as text, not [object Object].
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    type:choreMaintenance, deps, tests, docs

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions