Complex Sparse CSC#528
Merged
michel2323 merged 5 commits intomasterfrom Sep 25, 2025
Merged
Conversation
Contributor
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
Member
Author
|
For the complex cases, I can also post a warning that performance is degraded due to additional allocation. I think it might still be valuable in some cases. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #528 +/- ##
==========================================
- Coverage 80.01% 79.37% -0.64%
==========================================
Files 45 45
Lines 2887 2972 +85
==========================================
+ Hits 2310 2359 +49
- Misses 577 613 +36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@michel2323 Is it fine for you to merge my PR before and then rebase your PR on top of it? |
9040ac3 to
dabcbd3
Compare
dabcbd3 to
34bd06d
Compare
amontoison
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@amontoison Sorry, I also worked on it yesterday 🙂. This support Complex and throws errors for the trsm etc.