Honor IndexAttribute on header collection mappings - #2389
Open
justadityaraj wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With headers enabled, auto-mapping dropped every enumerable member before applying its attributes. A collection declared with
[Index(...)]was therefore left unmapped, even though the equivalent explicitClassMapworked.Fix
Keep skipping unindexed enumerable members, but retain collections that declare an
IndexAttribute. Add a regression test for the reported[Index(2, -1)]case.User impact
Collection properties can now use index ranges with attribute-based mapping when a CSV has headers, matching explicit class-map behavior.
Verification
mastergit diff --checkFixes #2364