-
Notifications
You must be signed in to change notification settings - Fork 30
Alert track matching ai #969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Work with the pull request https://code.jlab.org/hallb/clas12/coatjava/networks/-/merge_requests/5 |
|
@baltzell Hi, I think the unittest fails because it uses cvmfs to get the networks, and it is the wrong commit of the networks repo. |
Makes sense, assuming cvmfs is behind. I pushed a commit to switch the relevant CI jobs to use LFS. |
|
Thanks Chris |
|
Mathieu, can you describe conceptually what these changes amount to? |
|
Sure, here is a summary. Let me know if you’d like more details: Changes in the pull request:
|
sorry, could you put this in the PR description up top, please? |
|
No problem, it's now in the first comment. |
601a7cc to
971d20e
Compare
…ers and link them to their associated track. - Introduced new intercluster data structure in alert.json to store track ID and coordinates. - Add to InterCluster class the track ID. - Rename TrackConstruction to TrackCandidatesGenerator. - Updated Track class to manage interclusters and clusters and set track IDs. - Modified AHDCEngine to have similar interface for AI and conventional track finding. - Use the AI precluster algorithm for everthings (CV and AI)
971d20e to
3f5f733
Compare
* Start an implementation for the track matching for ALERT * Fix the path for the ALERT AI models * ALERT: Improve the AI model for track finding * ALERT: Change name of the model class for the track finding * ALERT: Rename some variables and class (Mode to ModeTrackFinding) * ALERT: change superpreclusters to InterCluster * Move the track matching to the ALERT Engine * ALERT: change the structure of the AHDCEngine to write the interclusters and link them to their associated track. - Introduced new intercluster data structure in alert.json to store track ID and coordinates. - Add to InterCluster class the track ID. - Rename TrackConstruction to TrackCandidatesGenerator. - Updated Track class to manage interclusters and clusters and set track IDs. - Modified AHDCEngine to have similar interface for AI and conventional track finding. - Use the AI precluster algorithm for everthings (CV and AI) * Fix the track matching AI and the output bank * Add the model and fix the constant loader in the ATOF * Modify HipoDataSync initialization in AHDCEngine * Update model path for TrackMatchingAI to use the new path for AI models * Remove the AI networks * Update model path for ALERT model in ModelTrackFinding * Update model path for TrackMatchingAI * fix(ci): use `--lfs` with `--unittests` --------- Co-authored-by: Christopher Dilks <c-dilks@users.noreply.github.com>
* Start an implementation for the track matching for ALERT * Fix the path for the ALERT AI models * ALERT: Improve the AI model for track finding * ALERT: Change name of the model class for the track finding * ALERT: Rename some variables and class (Mode to ModeTrackFinding) * ALERT: change superpreclusters to InterCluster * Move the track matching to the ALERT Engine * ALERT: change the structure of the AHDCEngine to write the interclusters and link them to their associated track. - Introduced new intercluster data structure in alert.json to store track ID and coordinates. - Add to InterCluster class the track ID. - Rename TrackConstruction to TrackCandidatesGenerator. - Updated Track class to manage interclusters and clusters and set track IDs. - Modified AHDCEngine to have similar interface for AI and conventional track finding. - Use the AI precluster algorithm for everthings (CV and AI) * Fix the track matching AI and the output bank * Add the model and fix the constant loader in the ATOF * Modify HipoDataSync initialization in AHDCEngine * Update model path for TrackMatchingAI to use the new path for AI models * Remove the AI networks * Update model path for ALERT model in ModelTrackFinding * Update model path for TrackMatchingAI * fix(ci): use `--lfs` with `--unittests` --------- Co-authored-by: Christopher Dilks <c-dilks@users.noreply.github.com>
Changes in the pull request: