Move Kalman Filter in ALERT engine#1100
Merged
baltzell merged 9 commits intoJeffersonLab:developmentfrom Feb 9, 2026
Merged
Conversation
Collaborator
ftouchte
commented
Feb 9, 2026
- Move Kalman Filter in ALERT engine
- Require/Read AHDC::track and AHDC::hits form AHDCEngine
- Remove redundant attributes in the object Track (delete everything with the _kf extension)
- Initialise the Kalmaan filter with Niter (number of iterations) and particle (PDGParticle type)
- Update AHDC::hits in ALERT engine after the Kalman Filter
…, make propagation public
Collaborator
|
Is this now loading the AHDC geometry twice? (Once in AHDC's engine and once in ALERT's) |
Collaborator
Author
|
Yes. I noticed that there is something similar for the ATOF. I think it is one of the limitation of using three different engines. |
Collaborator
|
It's not a limitation of the 3 engines, but we can address it later if necessary. It's only memory:) |
Collaborator
|
The approve button seems to have disappeared since last week. Anyone else seeing the same? |
baltzell
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.