Skip to content

Use react/lib/EventListener instead of document.addEventListener - #177

Closed
xcatliu wants to merge 1 commit into
JedWatson:masterfrom
xcatliu:event
Closed

Use react/lib/EventListener instead of document.addEventListener#177
xcatliu wants to merge 1 commit into
JedWatson:masterfrom
xcatliu:event

Conversation

@xcatliu

@xcatliu xcatliu commented May 8, 2015

Copy link
Copy Markdown

document.addEventListener doesn't work on IE8.

Use react/lib/EventListener instead of document.addEventListener will solve this problem.

@dcousens

dcousens commented May 9, 2015

Copy link
Copy Markdown
Collaborator

@xcatliu please see the CONTRIBUTOR file, you should only edit files in src. Not lib. Please fix.

@JedWatson

Copy link
Copy Markdown
Owner

The React team has made it clear that using React internals in other packages is not safe; as tempting as it is to reach in and access these utils, we should find a better way.

@dcousens

Copy link
Copy Markdown
Collaborator

Closing, will open a relevant issue though. @xcatliu please re-open if you rebase and submit a new/different fix.

@dcousens dcousens closed this May 11, 2015
@xcatliu

xcatliu commented May 12, 2015

Copy link
Copy Markdown
Author

@dcousens @JedWatson
Ok, I'll find a better way. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants