Fix the GH-4516 negative control that is failing CI on every PR

[jeremydmiller]

This is what is making #4553, #4557 and #4558 all fail. All three fail on exactly one job (test, ~5 min) with the same assertion, two of them from contributors. It is my regression from #4551, live on main since yesterday.

[FAILED] Wolverine.Http.Tests.unknown_tenant_problem_details_4516.without_the_opt_in_the_unknown_tenant_still_escapes
  Shouldly.ShouldAssertException : Task `async () => await host.Scenario(...)`
      should throw JasperFx.MultiTenancy.UnknownTenantIdException
      but threw Alba.ScenarioAssertionException

What was wrong

The test was self-contradictory. It asked Alba to assert a 404 inside a scenario it expected to throw:

await Should.ThrowAsync<UnknownTenantIdException>(async () =>
    await host.Scenario(x =>
    {
        x.Get.Url("/gh4516/tenanted?tenantId=ghost");
        x.StatusCodeShouldBe(404);      // <- asserted on a request expected to blow up
    }));

Locally the UnknownTenantIdException propagated before Alba evaluated its assertions, so the expected exception won and it passed. On CI the host turns the exception into a 500 first, so Alba's own 404 assertion fires and raises ScenarioAssertionException — a different type, so Should.ThrowAsync fails.

The fix

The control's purpose is narrower than what it asserted: it exists to show that MapUnknownTenantToNotFound() is what produces the 404, not something else in the pipeline. It is not a claim about how an unmapped failure surfaces — and that is precisely the part that varies by environment.

It now uses IgnoreStatusCode() and asserts only that the response is not a mapped 404, tolerating the other surfacing (the exception escaping the scenario) and nothing else — an unexpected exception type still fails.

On my part in this

The local suite was green when I merged #4551, so I had no signal. But I wrote an assertion that could only hold under one of two environment-dependent behaviours and didn't notice I'd coupled the control to the wrong thing. Worth flagging given it blocked two contributors' PRs overnight.

Wolverine.Http.Tests  unknown_tenant_problem_details_4516  5/5

🤖 Generated with Claude Code

https://claude.ai/code/session_01VDUrBeB4tTnKj4AExCS1nj