Support FromMethod on WriteAggregate for custom ID resolution#2458
Merged
Conversation
WriteAggregateAttribute.FindIdentity() hardcoded ValueSource.Anything, ignoring the ValueSource property set by FromMethod and other base class properties. Now checks if a specific ValueSource has been set and uses the inherited tryFindIdentityVariable() which respects it, falling back to the existing FindIdentity() logic for backward compatibility. Closes #2451 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Apr 9, 2026
This was referenced Apr 18, 2026
This was referenced Apr 25, 2026
This was referenced May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[WriteAggregate]now supportsFromMethod,FromRoute,FromHeader, andFromClaimfor custom aggregate ID resolution, matching the existing behavior of[ReadAggregate]ValueSourcehas been set (e.g. viaFromMethod), the inheritedtryFindIdentityVariable()is used first, which respects theValueSourceproperty. Falls back to the existingFindIdentity()logic for full backward compatibility.Example
Closes #2451
Test plan
🤖 Generated with Claude Code