Skip to content

Rename Primary Key constraint name when PK is also a foreign key#43

Merged
oskardudycz merged 2 commits into
JasperFx:masterfrom
tonykaralis:primarykeyconstraintmigrationcommand
Oct 24, 2021
Merged

Rename Primary Key constraint name when PK is also a foreign key#43
oskardudycz merged 2 commits into
JasperFx:masterfrom
tonykaralis:primarykeyconstraintmigrationcommand

Conversation

@tonykaralis

Copy link
Copy Markdown
Contributor
  • Adds test
  • Adds condition to ensure the alter/rename command is only run when the PK constraint names changes and not when the PK column is changed.

@tonykaralis

Copy link
Copy Markdown
Contributor Author

I did run all the tests and they pass locally, although there is definitely some flakiness even locally as some of them fail when run concurrently.

@oskardudycz oskardudycz added the bug Something isn't working label Oct 24, 2021
@oskardudycz oskardudycz added this to the 1.0.4 milestone Oct 24, 2021
@oskardudycz oskardudycz merged commit 5a73995 into JasperFx:master Oct 24, 2021
@oskardudycz oskardudycz linked an issue Oct 24, 2021 that may be closed by this pull request
@tonykaralis tonykaralis deleted the primarykeyconstraintmigrationcommand branch October 25, 2021 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to drop PK constraint during migration

2 participants