Repository navigation
Move the Aspire sample to Aspire.AppHost.Sdk 13.6.3 with a PostgreSQL resource; drop the workload step (#5724) - #5748
Merged
Conversation
… resource; drop the workload step (#5724) - src/samples/AspireHost is on Aspire.AppHost.Sdk/13.6.3 instead of the workload-era IsAspireHost with Aspire.Hosting.AppHost 8.2.0. The SDK references Aspire.Hosting.AppHost implicitly, so its central PackageVersion entry is removed (NU1009). Aspire.Hosting.PostgreSQL 13.6.3 added. - The AppHost provisions PostgreSQL (AddPostgres + AddDatabase) and passes it to both services with WithReference + WaitFor. The services read ConnectionStrings:marten, falling back to the test connection string when run on their own. Both are database-per-tenant (MultiTenantedWithSingleServer), which needs the server's connection string, so they read the string rather than using AddNpgsqlDataSource + UseNpgsqlDataSource(). - AspireHeadlessTripService had not compiled for some time (stale Marten.Events.Daemon.Resiliency and projection namespaces). It is in no solution, so nothing noticed. - The publish workflow no longer installs the aspire workload, obsolete since Aspire 9. ./build.sh pack does not build the sample. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
This was referenced Oct 24, 2026
Open
This was referenced Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5724.
AppHost
src/samples/AspireHostmoves from the workload-era<IsAspireHost>withAspire.Hosting.AppHost8.2.0 to<Project Sdk="Aspire.AppHost.Sdk/13.6.3">. 13.6.3 shipped after the issue named 13.6.2.Aspire.Hosting.AppHostimplicitly, so its centralPackageVersionentry is removed; keeping it is NU1009. A comment inDirectory.Packages.propssays to keepAspire.Hosting.PostgreSQL13.6.3 in step with the Sdk version.AddPostgres("postgres").AddDatabase("marten"). Both services getWithReferenceandWaitFor.IncludeMartenDedupeAliases=falseon the AppHost: it references no Marten, JasperFx or Weasel assembly, so the repository-wide global-using aliases had nothing to bind to.Services: one deviation from the issue's proposal
EventPublisherandAspireHeadlessTripServicereadConnectionStrings:martenfrom Aspire, falling back to the test connection string when run on their own.The issue proposed
AddNpgsqlDataSource("marten")plusUseNpgsqlDataSource(). Both services are database-per-tenant (MultiTenantedWithSingleServer), which needs the server's connection string to create each tenant's database, not oneNpgsqlDataSource. They therefore read the string, and a comment at each call site says why. The single-databaseUseNpgsqlDataSource()path is already the one shown indocs/getting-started.md.Stale sample code
AspireHeadlessTripServicehad not compiled for some time: it used the staleMarten.Events.Daemon.Resiliencynamespace and old projection namespaces. It is in no solution, so nothing noticed. Fixed here.Publish workflow
on-manual-do-nuget-publish.ymlno longer runsdotnet workload install aspire. That workload has been obsolete since Aspire 9, and./build.sh packdoes not build the sample.Verified
dotnet build src/samples/AspireHost/AspireHost.csprojbuilds the AppHost and both services with 0 errors. I did not launch the AppHost; that needs Docker and the Aspire dashboard.🤖 Generated with Claude Code