Repository navigation
test(server): take upstream's clock pin for the saved-usage window test - #882
Merged
Merged
Conversation
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
This review includes 2 billable files and costs up to $0.50.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 24 minutes for your next included review. View limit details
|
Jacksondr5
commented
Nov 1, 2026
Jacksondr5
left a comment
Owner
Author
There was a problem hiding this comment.
Combined panel review (reviewer-opus + reviewer-sol) at 3b9910b
Verdict: no findings, and the panel approves this test-only PR.
- The PR range from the merge base touches exactly
FORK.mdandapps/server/src/usage/UsageService.test.ts. - The test hunk is upstream's, unchanged. Its added and removed lines are byte-identical to
1280ccd0d2(pingdotgg#28603), which touches only that file. It setsTestClockto 2026-08-15, near the transcript's write, and providesTestClock.layer(). That ends the wall-clock dependency that broke the test once the 2026-08-01 transcript fell outside the 92-day window. We're approving the identical hunk only, not claiming the whole file equals upstream's: other parts differ because of the pin. - FORK.md adds one "Temporary in-place patches" bullet, with the exit "take upstream's at the next advance", and one ledger row.
- Reviewer-run:
UsageService.test.tspasses (40).
Reviewed by Claude Opus 5.5 (reviewer-opus) and Sol 6.1 (reviewer-sol) in J5 Code.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
From 2026-11-01,
UsageService.test.ts› "reports saved usage of a removed directory only for windows it reaches" fails onj5/mainand on every PR. The test runs on the wall clock with a transcript dated 2026-08-01. The usage service prunes saved usage older than 92 days, so from today the first read returns nothing.What changed
apps/server/src/usage/UsageService.test.ts: upstream's fix, cherry-picked unchanged. It's1280ccd0d2, "test(server): pin clock in saved-usage window test" (test(server): pin clock in saved-usage window test pingdotgg/t3code#28603). The test setsTestClockto 2026-08-15, near the write, and providesTestClock.layer(). The hunk is identical to upstream's.It touches nothing else. The Captain approved taking upstream's own test-only fix unchanged, the same pattern as #877.
Live testing
None: this is a test-only change.
vp test run src/usage/UsageService.test.tspasses (40 tests) at the head.Upstream impact
Edits upstream's test file only, with upstream's own change; recorded in FORK.md as a temporary patch.
Checklist
FORK.md(temporary patch entry and ledger row)Built by Claude Opus 5.5 in J5 Code (Claude Code harness).
🤖 Generated with Claude Code