Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/server/src/j5/a2a/CrewLaunchService.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -809,7 +809,7 @@ it.effect(
assert.equal(resolved.runtimeMode, "approval-required");
assert.equal(resolved.runtime.harness, "Claude Code");
assert.equal(resolved.runtime.reasoning, "low");
assert.equal(resolved.runtime.access, "Approval required");
assert.equal(resolved.runtime.access, "Supervised");
assert.deepStrictEqual(resolved.runtime.modelSelection, custom.modelSelection);
assert.equal(resolved.runtime.runtimeMode, custom.runtimeMode);
const instance = yield* launcher.launch({
Expand Down Expand Up @@ -876,7 +876,7 @@ it.effect(
])
.pipe(Effect.flip);
assert.equal(invalidAccess._tag, "CrewLaunchSeatUnavailableError");
assert.include(invalidAccess.message, "Choose Approval required or Full access");
assert.include(invalidAccess.message, "Choose Supervised or Full access");
// Neither configured provider advertises Critic's saved model: the human override
// still launches, preserving its snapshot and behavior on the selected harness.
const personaSeat = {
Expand Down
4 changes: 2 additions & 2 deletions apps/server/src/j5/a2a/CrewLaunchService.ts
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ export const layer = Layer.effect(
seatName: seat.name,
agentId: "custom seat",
detail:
"This ACP harness cannot enforce the selected access mode. Choose Approval required or Full access.",
"This ACP harness cannot enforce the selected access mode. Choose Supervised or Full access.",
});
// Custom seats carry the selected access mode, without a persona sandbox assignment.
resolved.push({
Expand Down Expand Up @@ -377,7 +377,7 @@ export const layer = Layer.effect(
seatName: seat.name,
agentId,
detail:
"This ACP harness cannot enforce the selected access mode. Choose Approval required or Full access.",
"This ACP harness cannot enforce the selected access mode. Choose Supervised or Full access.",
});
// The obligation is read from the same immutable snapshot the seat will run on, so a
// later library edit cannot change what a running seat owes.
Expand Down
4 changes: 2 additions & 2 deletions apps/server/src/j5/a2a/CrewProposalsHttp.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ it("lists open proposals for readers and resolves them only for operators", asyn
harness: "Claude Code",
model: "Claude Fable 5.1",
reasoning: "High",
access: "Approval required",
access: "Supervised",
modelSelection: customSeat.modelSelection,
runtimeMode: customSeat.runtimeMode,
},
Expand Down Expand Up @@ -155,7 +155,7 @@ it("lists open proposals for readers and resolves them only for operators", asyn
harness: "Claude Code",
model: "Claude Fable 5.1",
reasoning: "High",
access: "Approval required",
access: "Supervised",
modelSelection: customSeat.modelSelection,
runtimeMode: customSeat.runtimeMode,
},
Expand Down
4 changes: 2 additions & 2 deletions apps/server/src/j5/a2a/crewRuntimePreview.ts
Original file line number Diff line number Diff line change
Expand Up @@ -126,8 +126,8 @@ export function describeCrewSeatRuntime(
: mode === "auto"
? "Auto"
: mode === "auto-accept-edits"
? "Accept edits"
: "Approval required";
? "Auto-accept edits"
: "Supervised";
return {
seat,
provider: providerName(provider, model?.subProvider),
Expand Down
2 changes: 1 addition & 1 deletion apps/web/src/j5/crew/crewSeatRuntime.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ describe("crew member edits", () => {
});

it.each(["auto", "auto-accept-edits"] as const)(
"switches unsupported ACP %s access to explicit Approval required",
"switches unsupported ACP %s access to explicit Supervised",
(runtimeMode) => {
const draft = { ...crewSeatDraft(seat), runtimeMode };
const acp = {
Expand Down
8 changes: 4 additions & 4 deletions apps/web/src/j5/crew/crewSeatRuntime.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,13 @@ export interface CrewSeatDraft {
export const CREW_ACCESS_OPTIONS = [
{
value: "approval-required",
label: "Approval required",
label: "Supervised",
description: "Ask before commands and file changes.",
},
{
value: "auto-accept-edits",
label: "Accept edits",
description: "Approve edits; ask before other actions.",
label: "Auto-accept edits",
description: "Auto-approve edits, ask before other actions.",
},
{
value: "auto",
Expand Down Expand Up @@ -82,7 +82,7 @@ export const crewModelSelection = (
return { instanceId: provider.instanceId, model: model.slug, ...(options ? { options } : {}) };
};

/** ACP cannot enforce Auto or Accept edits; a harness switch visibly chooses its supervised mode. */
/** ACP cannot enforce Auto or Auto-accept edits; a harness switch visibly chooses its supervised mode. */
export const chooseCrewHarness = (
draft: CrewSeatDraft,
provider: Pick<ServerProvider, "instanceId" | "driver">,
Expand Down
Loading