Skip to content

chore(web): inbox and fleet rail entries use inbox and radar icons - #219

Merged
bryantderosier merged 2 commits into
j5/mainfrom
j5/rail-icons-inbox-radar
Sep 21, 2026
Merged

bryantderosier merged 2 commits into
j5/mainfrom
j5/rail-icons-inbox-radar

Conversation

@bryantderosier

Copy link
Copy Markdown
Collaborator

Closes #218

The Inbox control in the sidebar header showed a notification bell while the Inbox page it opens uses the inbox tray icon, and the Fleet control showed the same people icon family the Personas settings entry uses. Neither icon said what it opened.

I swapped the bell for lucide's InboxIcon and the people icon for lucide's RadarIcon, and updated the two lines in the user guide that called the control the "inbox bell". Both components are J5-owned, so no upstream file changed and the FORK.md inventory is unchanged. Mobile has no equivalent rail controls.

Verified with the web app typecheck, lint on the two files, the existing HumanInboxBell unit test, and a format check.

Built with Claude Fable 5.1 in Claude Code.

🤖 Generated with Claude Code

The Inbox control in the sidebar header showed a notification bell while
the Inbox page itself uses the inbox tray icon, and the Fleet control
showed the people icon that Personas already uses. Both rail entries now
show an icon for the page they open: the inbox tray for Inbox and a radar
for Fleet. The user guide no longer calls the control the "inbox bell".

Closes #218

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@bryantderosier bryantderosier added the j5 branding J5 fork identity: icons, wordmark, and branding label Sep 21, 2026
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 effective changed lines (test files excluded in mixed PRs). labels Sep 21, 2026
@bryantderosier bryantderosier self-assigned this Sep 21, 2026
Shiki stops tokenizing a line after 500 ms of wall clock, stretches the
last matched token to the end of that line, and carries the halted grammar
state into the next line. On a loaded CI runner a cold regex engine crossed
that budget on the first template literal, so "keeps grammar state across
inline comment rows" saw the closing row highlighted from the wrong state
while the same commit passed in another run.

The file now freezes Date.now for every test, the same fixture treatment
shikiReviewHighlighter.test.ts already uses, so the tests measure grammar
state handling and not runner speed. The runtime budget is unchanged. The
FORK.md fixtures entry records the new test delta.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@bryantderosier
bryantderosier merged commit 8891976 into j5/main Sep 21, 2026
21 checks passed
@bryantderosier
bryantderosier deleted the j5/rail-icons-inbox-radar branch September 21, 2026 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

j5 branding J5 fork identity: icons, wordmark, and branding size:S 10-29 effective changed lines (test files excluded in mixed PRs). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(web): inbox and fleet rail icons should say what they open

2 participants