Skip to content

docs(sessions): record the sessions switch as a feature-flag chapter - #996

Merged
JSdotNet merged 1 commit into
mainfrom
schedule/issue-sweep/2026-10-05/881-sessions-turn-the-area-off-drift
Oct 5, 2026
Merged

JSdotNet merged 1 commit into
mainfrom
schedule/issue-sweep/2026-10-05/881-sessions-turn-the-area-off-drift

Conversation

@JSdotNet

@JSdotNet JSdotNet commented Oct 5, 2026

Copy link
Copy Markdown
Owner

Closes #881

What changed

I fixed the drift in issue #881 by editing the devbook only. The code on main is right and the chapter was behind. No source or test file changed. Nothing was committed.

  1. New flag chapter. D:/iswp/881-sessions-turn-the-area-off-drift/.devbook/domain/sessions/context.md now has a ## Sessions area chapter after the boundary prose. Its meta block is status: draft, type: feature-flag, key: sessions, default: on, with related pointing at features.md#turn-the-area-off. The prose follows the Dashboard, Inbox pane and System tools chapters. It says:
    • turning the switch on shows the Sessions segment and its list in the Home shell;
    • switching it off removes list_sessions and the eight delivery-surface operations from the MCP endpoint, and stops the dashboard's hours worked and the roadmap's actual hours from reading agent activity;
    • the switch is on by default and marked DEV;
    • the key is SessionFeatures.Sessions in the Sessions module, and its string has not changed since it lived on DevPcFeatures;
    • the settings screen lists it from AppFeatures.cs, and the person's choice is kept in features.json;
    • it is retired when the Sessions area leaves DEV.
  2. Link back from the feature. In D:/iswp/881-sessions-turn-the-area-off-drift/.devbook/domain/sessions/features.md, only the ## Turn the area off section changed:
    • its meta block gains feature-flag: .devbook/domain/sessions/context.md#sessions-area;
    • it gains a tests: list naming the six existing tests that prove the switch-off behaviour;
    • one sentence now names what else the switch withdraws: the MCP tools and the two hours readings.

Verification:

  • Before the edit: build.mjs --check exited 0 with 314 warnings. check-metadata.mjs exited 0 with 0 blocking and 287 advisory findings.
  • Failing step: with only the feature-flag reference added, build.mjs --check exited 1 with the expected error: the feature-flag reference to context.md#sessions-area does not resolve.
  • After the flag chapter was added: build.mjs --check exited 0 with the same 314 warnings; comparing the warnings with line numbers ignored showed no difference. check-metadata.mjs output was identical to the baseline.
  • DevbookBuilderParityTests passed (2 of 2).
  • The diff touches only those two files, and a scan of both found no control bytes.

Acceptance criteria

    1. sessions/context.md has a feature-flag chapter (key sessions, default on, related turn-the-area-off) with a business-name heading — not proved by a test — check by hand
    1. Flag prose says what on/off changes, DEV and default on, SessionFeatures.Sessions, AppFeatures.cs/features.json, retirement — not proved by a test — check by hand
    1. Turn the area off meta carries feature-flag to the new chapter and it resolves — proved by node .devbook/_tools/devbook-meta/build.mjs --check (failed on the unresolved feature-flag reference before the chapter was added, passes after)
    1. No other features.md section changes; nothing under src/, tests/, _tools/, _meta/ changes — not proved by a test — check by hand
    1. build.mjs --check and check-metadata.mjs pass with no new errors — proved by node .devbook/_tools/devbook-meta/build.mjs --check (exit 0, warnings identical to baseline) and node tools/devbook/check-metadata.mjs (exit 0, output identical to baseline); DevbookBuilderParityTests also pass

Verification

  • Command: cd "D:/iswp/881-sessions-turn-the-area-off-drift" && dotnet build Backlog.sln && dotnet test Backlog.sln
  • Build: passed; tests: passed — 11482 passed, 0 failed
  • Repair attempts: 1
  • Notes: The build passed: 0 warnings and 0 errors. The worktree diff after repair attempt 1 touches only .devbook/domain/sessions/context.md and .devbook/domain/sessions/features.md, with no src/ or tests/ changes. I ran the test suite twice. On the first run, Backlog.Desktop.UI.UnitTests reported 3 errors and the overall result was Failed. I re-ran it straight away with no changes, and every assembly passed: total 11483, succeeded 11482, failed 0, skipped 1, duration 45s 831ms. The diff touches only devbook files, and that assembly has a known history of foreground-thread and timing flakes under load. So the first-run failure looks like a flake and not a regression, but I don't have the failing test names to confirm it. Full log of the passing rerun: C:/Users/jobsc/AppData/Local/Temp/claude/D--Repos-Backlog--claude-worktrees-delivery-schedule-issue-sweep-764a6e/8479bbce-a0bd-4843-afc7-4c6ae5619846/scratchpad/t881.log. I fixed nothing.

Review

  • No findings.

What could not be proved

  • 3 acceptance criterion/criteria have no test proving them: "1. sessions/context.md has a feature-flag chapter (key sessions, default on, related turn-the-area-off) with a business-name heading"; "2. Flag prose says what on/off changes, DEV and default on, SessionFeatures.Sessions, AppFeatures.cs/features.json, retirement"; "4. No other features.md section changes; nothing under src/, tests/, _tools/, _meta/ changes"
  • The run took 12 assumption(s) instead of asking: Assumed default: on, because the catalog entry has no EnabledByDefault: false.; Assumed the flag chapter is headed ## Sessions (slug sessions), following the Dashboard precedent of naming it after the area.; Assumed the chapter carries status: draft like the sibling DEV flag chapters, since the key is still Status Dev.; Whether to also name in prose that the switch stops dashboard hours worked and roadmap actual hours from reading agent activity. These are real effects in the code that the issue does not list; assumed they may go in the flag chapter's prose without widening the change.; Whether to add a tests: field to the feature and flag chapters. Assumed yes, using the HomeWorkspaceSurfaceTests and McpEndpointGateTests names, since the metadata rules allow it on feature-flag and feature chapters.; The pull-requests key (SessionFeatures.PullRequests, default off) also has no switch chapter. Left out of scope because the issue does not name it; it could be its own drift issue.; The chapter was behind and the code is right, so the verdict is code-ahead and no source change was made.; I headed the flag chapter ## Sessions area (slug sessions-area) instead of ## Sessions, so its slug cannot collide with the file's # Sessions title.; I gave the flag chapter status: draft, matching the precedent flag chapters (Dashboard, Inbox pane, System tools). The existing Turn the area off meta block has no status, so I did not add one there.; The retirement condition, 'when the Sessions area leaves DEV', copies the Dashboard and System tools precedents. No code or ADR states when this flag is retired.; The separate pull-requests key (SessionFeatures.PullRequests) also has no flag chapter. It is out of scope and was left alone.; Following the sweep's instructions, I did not invoke delivery:flow-spec in this subagent; the session running the sweep owns the flow and the git side effects.

Assumptions

  • Assumed default: on, because the catalog entry has no EnabledByDefault: false.
  • Assumed the flag chapter is headed ## Sessions (slug sessions), following the Dashboard precedent of naming it after the area.
  • Assumed the chapter carries status: draft like the sibling DEV flag chapters, since the key is still Status Dev.
  • Whether to also name in prose that the switch stops dashboard hours worked and roadmap actual hours from reading agent activity. These are real effects in the code that the issue does not list; assumed they may go in the flag chapter's prose without widening the change.
  • Whether to add a tests: field to the feature and flag chapters. Assumed yes, using the HomeWorkspaceSurfaceTests and McpEndpointGateTests names, since the metadata rules allow it on feature-flag and feature chapters.
  • The pull-requests key (SessionFeatures.PullRequests, default off) also has no switch chapter. Left out of scope because the issue does not name it; it could be its own drift issue.
  • The chapter was behind and the code is right, so the verdict is code-ahead and no source change was made.
  • I headed the flag chapter ## Sessions area (slug sessions-area) instead of ## Sessions, so its slug cannot collide with the file's # Sessions title.
  • I gave the flag chapter status: draft, matching the precedent flag chapters (Dashboard, Inbox pane, System tools). The existing Turn the area off meta block has no status, so I did not add one there.
  • The retirement condition, 'when the Sessions area leaves DEV', copies the Dashboard and System tools precedents. No code or ADR states when this flag is retired.
  • The separate pull-requests key (SessionFeatures.PullRequests) also has no flag chapter. It is out of scope and was left alone.
  • Following the sweep's instructions, I did not invoke delivery:flow-spec in this subagent; the session running the sweep owns the flow and the git side effects.

Opened as a draft by an unattended run of delivery-schedule:schedule-issue-sweep (2026-10-05).

🤖 Generated with Claude Code

The Turn the area off feature described one switch for the Sessions area
that the devbook never recorded. Add a "Sessions area" feature-flag
chapter to sessions/context.md (key sessions, DEV, default on) naming
what it withdraws - the Home segment and list, the list_sessions and
delivery-surface MCP tools, and the agent-activity hours - and point the
feature's meta block at it.

Refs #881

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@JSdotNet
JSdotNet marked this pull request as ready for review October 5, 2026 19:51
@JSdotNet
JSdotNet enabled auto-merge October 5, 2026 22:24
@JSdotNet
JSdotNet merged commit 7d14807 into main Oct 5, 2026
20 of 23 checks passed
@JSdotNet
JSdotNet deleted the schedule/issue-sweep/2026-10-05/881-sessions-turn-the-area-off-drift branch October 5, 2026 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Devbook drift] .devbook/domain/sessions/features.md#turn-the-area-off

1 participant