[JSdotNet]

Summary

A post-merge review of everything that landed on 19 and 20 August (#137 through #167), asking whether the pieces combined well and what they left behind.

Mostly they did. The combined state builds clean with no warnings, all tests pass, the solution matches what is on disk with nothing orphaned or dangling, no conflict markers survived any of the six Merge origin/main resolutions, every _meta graph is current, and all 55 .design anchors the storybook names resolve. The two headline renames are coherent rather than half-finished: the BacklogEntry → TaskItem drift in .domain/ is deliberately recorded in naming.md as deferred to orch-domain, and ADR 0003 explicitly addresses why Roadmap Planning stayed on JSON while tasks moved to SQLite. The three riskiest seams all merged correctly — WorkspaceSurface grew a fourth state with matching header segment, gating and Escape handling; DataTable arrived from the Sessions branch with RowKey set to Kind/Id so cross-agent id collisions cannot corrupt Blazor's keyed diff; Sessions' adapters follow the Dashboard.UI/Adapters/ precedent.

So this PR is the residue, not a repair.

Changes

A locked session file no longer costs an agent its whole list. Both readers guarded the parse of a live-session file but not the open of it — and these files are written by the process they describe, so a sharing violation is an ordinary event. The IOException escaped to LocalAgentSessionSource.Collect, which reads it as "this agent's folder cannot be read" and blanks every row it would have produced. The Claude reader's own comment already said that losing one row is the proportionate response to a file being rewritten underneath it; now the code does that.

The storybook's design references are enforced rather than hoped for. The restructure moved the rules into .design and had each page name a chapter and anchor, which DesignGuideline renders beside the component. Rename a heading and the page silently draws a sentence saying the rule is missing — in a host nothing in CI opens. Every other convention in this library is a test, so this one is now too, slugging headings the way GitHub does because that is what resolves these anchors everywhere else they are written.

README.md had drifted furthest, because four merges added projects to it and none updated it. Twelve of the forty-six were missing: all of Sessions, the Roadmap module and its Abstractions, Infrastructure.Sqlite and three other adapters, the storybook host, six test projects. Worse than incomplete — it still called Infrastructure.FileSystem the canonical local data, which ADR 0003 made untrue; still called Roadmap "scaffolding only so far"; still described the .backlog folder join that went with the repository integration; still listed a Monitoring module that has no project; and still linked to the domain/ and architecture/ folders the restructure replaced.

Two stale comments from the merge seams: the surface switcher said "both takeover features" after Sessions made it three, and CLAUDE.md wrote src/harness where the solution file, the architecture tests and every other document write src/Harness.

Testing

dotnet build Backlog.sln clean with 0 warnings and dotnet test Backlog.sln fully green — run both before the fixes and again after merging origin/main (which had moved five commits ahead onto Home.razor, one of the files here).

The two new reader tests hold a real FileShare.None handle over one session file and assert the sibling row survives. Both were checked against the unfixed readers and fail there — the Copilot one aborted the whole reader. The new architecture test was checked the same way, by renaming a .design heading and confirming it goes red. It also passes against color-scheme.md as #167 rewrote it, which is the guard doing its job on content it never saw.

No Aspire instance was started for this review, so there was none to stop.

Related

• ADR 0003 — SQLite is the canonical local task store, which several of the README corrections bring the documentation into line with.
• Merged origin/main (Give every repository one colour, and show it everywhere #167, repository colours) into this branch so the overlap on Home.razor was resolved here rather than by a reviewer.

Two things left for you to decide

• tests/Backlog.Infrastructure.FileSystem.UnitTests now holds only JsonRoadmapPlanRepositoryTests. That adapter's own workspace-settings and feature-flag tests sit in Backlog.Desktop.UI.UnitTests, because they serialize on a collection fixture defined there. Not trivially movable, so the split is documented in the README row rather than papered over.
• .arc42/08-crosscutting-concepts.md names SQLite for tasks and JSON for settings and flags, but not the roadmap plan's own _roadmap/plan.json. A governed chapter, so it belongs to orch-arc42 rather than a drive-by edit here.

Also latent but harmless: the working directory is src/harness while git's index records src/Harness. Invisible on Windows under core.ignorecase, and since the index carries the casing everything references, a case-sensitive checkout gets the right name — nothing is broken, but it is why find and git ls-files disagree in this repo.

Checklist

• Scope is focused and excludes unrelated changes
• Documentation or instruction files were updated when governance or behavior changed
• Running Aspire instances for this checkout were stopped before PR creation — none was started for this review
• Follow-up work is captured when the implementation is intentionally partial — see "Two things left for you to decide"

🤖 Generated with Claude Code