fix(ci): build @loopover/contract before packing the MCP and miner packages - #9947
Merged
Conversation
…ckages Both publish workflows have failed on EVERY main commit for as long as the run history goes back -- three retries per push, never one success -- so neither package has actually been publishing. packages/loopover-contract/dist is gitignored. Both workflows already build @loopover/engine for exactly that reason, with a comment explaining it, but neither builds the contract -- and both packages import it: bin/loopover-mcp.ts(16,8): TS2307: Cannot find module "@loopover/contract/api-schemas" bin/loopover-miner-mcp.ts(5,44): TS2307: Cannot find module "@loopover/contract" Reproduced locally by deleting the contract dist/ and running each workflow's own build command: 9 unresolved imports for MCP, 7 for the miner. With the new step both pass. Scope is exactly these two: publish-contract already builds itself, and publish-engine / publish-mcp-registry / publish-ui-kit do not depend on the contract at all. The failure hides in a publish workflow rather than validate-*, so PR CI stays green and the gate is unaffected -- which is why "red on main" read as release noise instead of "this package has not shipped since it started importing the contract". Closes #9946
Contributor
|
Important 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏳ LoopOver is waiting…LoopOver has seen this pull request and is waiting on CI checks to finish before reviewing it. This comment will update once the review runs. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed · 🟨 Waiting |
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9947 +/- ##
=======================================
Coverage 91.88% 91.88%
=======================================
Files 928 928
Lines 113670 113670
Branches 27411 27411
=======================================
Hits 104440 104440
Misses 7931 7931
Partials 1299 1299
Flags with carried forward coverage won't be shown. Click here to find out more. |
This was referenced Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9946
Both publish workflows fail on every main commit, and have for as long as the run history goes back — three retries per push, never one success. Neither package has actually been publishing.
Root cause
packages/loopover-contract/distis gitignored. Both workflows already build@loopover/enginefor exactly that reason, with a comment explaining it — but neither builds the contract, and both packages import it:Verified, not assumed
Deleted the contract
dist/and ran each workflow’s own build command: 9 unresolved imports for MCP, 7 for the miner. Addednpm run build --workspace @loopover/contractand both pass.actionlintclean.Scope is exactly these two —
publish-contractalready builds itself, andpublish-engine/publish-mcp-registry/publish-ui-kitdon’t depend on the contract.Why it stayed invisible
The failure lives in a publish workflow, not
validate-*, so PR CI stays green and the gate is unaffected. Main’s rollup showed red, but it read as release noise rather than "this package has not shipped since it started importing the contract".Worth a separate look: three failed attempts per commit, indefinitely, is a pipeline telling nobody. A publish failing identically on consecutive commits should surface once, loudly, rather than re-failing quietly forever.