Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/db/repositories.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3765,6 +3765,10 @@ export async function listGateOutcomeAuditEventRollups(
and(
inArray(auditEvents.eventType, ["agent.action.merge", "agent.action.close", "agent.action.hold"]),
gte(auditEvents.createdAt, options.sinceIso),
// Exclude dry-run shadow actions, which agent-action-executor rewrites to outcome "completed" and so
// otherwise land in the terminal-outcome buckets. Mirrors public-accuracy-trend.ts's loadReversalDayRows:
// same COALESCE default of 'live', so a legacy row without a mode key is still counted (#9694).
sql`coalesce(json_extract(${auditEvents.metadataJson}, '$.mode'), 'live') <> 'dry_run'`,
repoFilter,
),
)
Expand Down
67 changes: 67 additions & 0 deletions test/unit/gate-outcome-audit-rollups.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,73 @@ describe("listGateOutcomeAuditEventRollups (#2203)", () => {
expect(rollups.some((row) => row.eventType === "agent.action.merge" && row.count > 1)).toBe(false);
});

it("excludes dry-run shadow actions but keeps live and legacy (no-mode) rows (#9694)", async () => {
const env = createTestEnv();
// A dry-run shadow: agent-action-executor rewrites its outcome to "completed", so it would otherwise land
// in the autoMerged bucket. The metadata.mode discriminator is the only thing that distinguishes it.
await recordAuditEvent(env, {
eventType: "agent.action.merge",
actor: "loopover",
targetKey: "octo/demo#1",
outcome: "completed",
metadata: { mode: "dry_run" },
createdAt: "2026-07-10T12:00:00.000Z",
});
// A real live action (explicit mode: "live").
await recordAuditEvent(env, {
eventType: "agent.action.merge",
actor: "loopover",
targetKey: "octo/demo#2",
outcome: "completed",
metadata: { mode: "live" },
createdAt: "2026-07-10T13:00:00.000Z",
});
// A legacy row with no mode key at all — COALESCE defaults to 'live', so it must still be counted.
await recordAuditEvent(env, {
eventType: "agent.action.close",
actor: "loopover",
targetKey: "octo/demo#3",
outcome: "success",
createdAt: "2026-07-10T14:00:00.000Z",
});

const rollups = await listGateOutcomeAuditEventRollups(env, {
repoFullNames: ["octo/demo"],
sinceIso: "2026-07-01T00:00:00.000Z",
});
// The live merge and the legacy close are counted; the dry-run merge is not (merge count is 1, not 2).
expect(rollups).toEqual(
expect.arrayContaining([
{ eventType: "agent.action.merge", outcome: "completed", count: 1 },
{ eventType: "agent.action.close", outcome: "success", count: 1 },
]),
);
expect(rollups.some((row) => row.eventType === "agent.action.merge" && row.count > 1)).toBe(false);
});

it("returns nothing for a repo whose window holds only dry-run shadow actions (#9694)", async () => {
const env = createTestEnv();
await recordAuditEvent(env, {
eventType: "agent.action.merge",
actor: "loopover",
targetKey: "octo/dry#1",
outcome: "completed",
metadata: { mode: "dry_run" },
createdAt: "2026-07-10T12:00:00.000Z",
});
await recordAuditEvent(env, {
eventType: "agent.action.close",
actor: "loopover",
targetKey: "octo/dry#2",
outcome: "completed",
metadata: { mode: "dry_run" },
createdAt: "2026-07-10T13:00:00.000Z",
});
await expect(
listGateOutcomeAuditEventRollups(env, { repoFullNames: ["octo/dry"], sinceIso: "2026-07-01T00:00:00.000Z" }),
).resolves.toEqual([]);
});

it("returns an empty rollup list when the scoped repo list is empty", async () => {
const env = createTestEnv();
await expect(listGateOutcomeAuditEventRollups(env, { repoFullNames: [], sinceIso: "2026-07-01T00:00:00.000Z" })).resolves.toEqual([]);
Expand Down