fix(mcp): include open issue counts in score breakdown - #971
Conversation
|
🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 🛠️ Maintainer review — Held for maintainer reviewReviewed 2 changed file(s) — two independent AI reviewers, synthesized. ✅ Safe to merge — both reviewers found no blocking issues.
Merge readiness: ✅ Mergeable · all CI checks green/neutral/skipped. Summary The change adds open issue count to the scoring breakdown by fetching contributor issues and integrating the count into the score input. Types compile (CI passed) and the new unit test validates the gate behavior. No security concerns are introduced, and the public/private sanitizer boundary remains intact. The modification is logically sound and does not break existing tests or functionality. 💡 Nits — non-blocking, optional
|
|
Note Gittensory Gate skippedPR closed before full evaluation. No late first comment was created.
💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #971 +/- ##
=======================================
Coverage 96.60% 96.61%
=======================================
Files 110 110
Lines 15073 15074 +1
Branches 5447 5447
=======================================
+ Hits 14562 14564 +2
+ Misses 107 106 -1
Partials 404 404 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
ghost
left a comment
There was a problem hiding this comment.
Held for maintainer (guardrail_area) — correct + CI green
Motivation
Description
listContributorIssuesforinput.contributorLoginin the MCPexplainScoreBreakdownhandler and compute the repo-specificopenIssueCountviacontributorOpenIssueCountbefore scoring. (modifiedsrc/mcp/server.ts)openIssueCountinto thescoreInputpassed tobuildScorePreviewso the scoring core receives the intended trusted open-issue value. (modifiedsrc/mcp/server.ts)gittensory_explain_score_breakdown applies trusted open-issue countsthat seeds contributor issues and asserts the open-issue gate appears in the tool output. (modifiedtest/unit/mcp-output-schemas.test.ts)Testing
npx vitest run test/unit/mcp-output-schemas.test.ts -t "trusted open-issue", and the new test passed.npm run typecheck(tsc --noEmit), which completed successfully.gateHighlightsand thatbuildScorePreviewnow receivesopenIssueCountduring the explain/score-breakdown flow.Codex Task