Skip to content

feat(openapi): document GET pulls/:number/ai-review-findings - #9405

Closed
philluiz2323 wants to merge 1 commit into
JSONbored:mainfrom
philluiz2323:fix/openapi-ai-review-findings-9305-v2
Closed

feat(openapi): document GET pulls/:number/ai-review-findings#9405
philluiz2323 wants to merge 1 commit into
JSONbored:mainfrom
philluiz2323:fix/openapi-ai-review-findings-9305-v2

Conversation

@philluiz2323

Copy link
Copy Markdown
Contributor

What

GET /v1/repos/:owner/:repo/pulls/:number/ai-review-findings is the only sibling of maintainer-packet and reviewability missing from the OpenAPI contract, despite sharing the same path family, auth boundary, and MCP-tool parity (loopover_get_pr_ai_review_findings / prAiReviewFindingsOutputSchema).

Change

  • Add PullRequestAiReviewFindingsSchema in src/openapi/schemas.ts matching prAiReviewFindingsOutputSchema
  • Register the schema and GET .../ai-review-findings path in src/openapi/spec.ts next to its siblings
  • Assert path + schema keys in test/unit/openapi.test.ts
  • Regenerate apps/loopover-ui/public/openapi.json

Closes #9305

Made with Cursor

…ed#9305)

ai-review-findings is the only sibling of maintainer-packet and reviewability
missing from the OpenAPI contract. Add PullRequestAiReviewFindingsSchema from
prAiReviewFindingsOutputSchema, register the path, assert it in openapi.test,
and regenerate apps/loopover-ui/public/openapi.json.

Closes JSONbored#9305
@philluiz2323
philluiz2323 requested a review from JSONbored as a code owner July 27, 2026 16:20
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.59%. Comparing base (b4064b6) to head (f903aa1).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9405      +/-   ##
==========================================
+ Coverage   75.46%   75.59%   +0.13%     
==========================================
  Files         275      277       +2     
  Lines       58030    58357     +327     
  Branches     6199     6206       +7     
==========================================
+ Hits        43790    44116     +326     
  Misses      13970    13970              
- Partials      270      271       +1     
Flag Coverage Δ
backend 99.69% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/openapi/schemas.ts 100.00% <100.00%> (ø)
src/openapi/spec.ts 99.49% <100.00%> (ø)

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 27, 2026
@loopover-orb

loopover-orb Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Warning

⏸️ LoopOver review result - manual review recommended

Review updated: 2026-07-27 17:01:39 UTC

4 files · 1 AI reviewer · no blockers · CI green · dirty

⏸️ Suggested Action - Manual Review

Review summary
The AI review returned non-blocking notes for this change but did not include a separate narrative summary. Review the nits below before deciding this PR.

Nits — 4 non-blocking
  • The magic HTTP status codes (200/400/403/404) in src/openapi/spec.ts:772-778 are plain literals, consistent with the rest of the file's existing pattern, so not worth changing here — just flagging per the external brief.
  • The regenerated apps/loopover-ui/public/openapi.json is a large generated diff; worth a quick diff-only sanity check that no unrelated schema entries shifted, though the shown hunks look isolated to the new schema/path.
  • Confirm in review that prAiReviewFindingsOutputSchema in src/mcp/server.ts is truly optional on repoFullName/pullNumber/login/findings/categoryCounts as mirrored here, since the OpenAPI schema marks them all optional except status — worth a one-line comment or link to that source of truth beyond the existing code comment.
  • test/unit/openapi.test.ts assertions use JSON.stringify(...).toContain(...) string matching rather than structural checks; matches the existing test file's convention so acceptable, but structural equality would be more robust long-term.

Decision drivers

  • ✅ Code review — No blockers (1 reviewer)
  • ✅ Gate result — Passing (No configured blocker found.)
Context & advisory signals — never blocks the verdict
Signal Result Evidence
Linked issue ✅ Linked #9305
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 992 registered-repo PR(s), 564 merged, 125 issue(s).
Contributor context ✅ Confirmed Gittensor contributor philluiz2323; Gittensor profile; 992 PR(s), 125 issue(s).
Improvement ✅ Minor risk: clean · value: minor
Review context
  • Author: philluiz2323
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: Python, JavaScript, MDX, TypeScript, CSS, Cuda, HTML, Kotlin
  • Official Gittensor activity: 992 PR(s), 125 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Keep the PR focused and include validation evidence before maintainer review.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask &lt;question&gt; answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat &lt;question&gt; answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

Visual preview
Route Viewport Before (production) After (this PR's preview) Diff
/ desktop before /
before /
after /
after /
/ mobile before / (mobile)
before / (mobile)
after / (mobile)
after / (mobile)

Click any thumbnail to open the full-size screenshot. Before = production · After = this PR's preview deploy.

Scroll preview
Route Before (production) After (this PR's preview)
/ before / (scroll)
before / (scroll)
after / (scroll)
after / (scroll)

A short scroll-through clip (desktop) — click either thumbnail to open the full animation. Evidence for scroll-linked behavior a single screenshot can't show.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb

loopover-orb Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

This pull request changes UI/visual code but its screenshot evidence is incomplete. Every required viewport × theme combination needs its own before/after image pair in a labeled table row (e.g. "Desktop · Light | before | after"). Still missing: Desktop · Dark, Tablet · Dark, Mobile · Dark.

Please resubmit with the remaining rows filled in.

See https://github.com/JSONbored/loopover/blob/main/.claude/skills/contributing-to-loopover/SKILL.md for the exact format and examples. This is an automated maintenance action.

@loopover-orb loopover-orb Bot closed this Jul 27, 2026
@JSONbored JSONbored reopened this Jul 27, 2026

@JSONbored JSONbored left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reopened to re-review, but merge conflicts, so re-closing.

This branch has conflicts that must be resolved
Use the web editor or the command line to resolve conflicts before continuing.

apps/loopover-ui/public/openapi.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

openapi: pulls/:number/ai-review-findings missing from spec, unlike its maintainer-packet + reviewability siblings

2 participants