fix(rules): align isCodePath with isCodeFile module/JVM extensions - #9386
Conversation
isCodePath lagged SOURCE_FILE_EXTENSION/isCodeFile for .mts/.cts/.mjs/.cjs/.kts/.scala/.groovy, so annotatablePullRequestFiles dropped those paths before Missing test evidence annotations could land. Add the seven extensions and a parity regression covering each. Closes JSONbored#9322
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9386 +/- ##
===========================================
- Coverage 89.46% 75.52% -13.95%
===========================================
Files 836 276 -560
Lines 109588 58391 -51197
Branches 26096 6341 -19755
===========================================
- Hits 98046 44100 -53946
- Misses 10279 14014 +3735
+ Partials 1263 277 -986
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Tip ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-27 15:43:52 UTC
Review summary Nits — 3 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Summary
isCodePathinsrc/rules/advisory.tslaggedSOURCE_FILE_EXTENSION/isCodeFilefor seven extensions (.mts,.cts,.mjs,.cjs,.kts,.scala,.groovy).annotatablePullRequestFilesgates onisCodePathbefore Missing test evidence annotations can land, so PRs whose only changed files use those extensions got zero inline annotations — the fourth instance of this same parity-drift class (Vue/Svelte/Astro, C++/hpp, Dart already fixed).Adds the seven extensions to
isCodePath(additive only) and a regression covering each path viabuildCheckRunAnnotations.Test plan
test/unit/rules.test.ts: new#9322parity test asserts Missing test evidence annotations for all seven extensionsCloses #9322