Skip to content

fix(miner): add blocked_own_open_pr to the AttemptCliResult union (#9331) #9384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loopover-orb merged 1 commit into from
Jul 27, 2026
Merged

fix(miner): add blocked_own_open_pr to the AttemptCliResult union (#9331) #9384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/loopover-miner/lib/attempt-cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ type CommonAttemptResultFields = {
export type AttemptCliResult =
| (CommonAttemptResultFields & { outcome: "dry_run" })
| (CommonAttemptResultFields & { outcome: "blocked_rejection_signaled"; reason: string })
| (CommonAttemptResultFields & { outcome: "blocked_own_open_pr"; reason: string; existingPullRequestNumber: number })
| (CommonAttemptResultFields & { outcome: "blocked_worktree_preparation_failed"; reason: string })
| (CommonAttemptResultFields & {
outcome: "blocked_infeasible";
Expand Down
25 changes: 24 additions & 1 deletion test/unit/miner-attempt-cli.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import { closeDefaultWorktreeAllocator, openWorktreeAllocator } from "../../pack
import { closeDefaultPortfolioQueueStore } from "../../packages/loopover-miner/lib/portfolio-queue";
import { closeDefaultGovernorState } from "../../packages/loopover-miner/lib/governor-state";
import { buildAttemptDeps, parseAttemptArgs, runAttempt, resolveAttemptHouseRulesConfig } from "../../packages/loopover-miner/lib/attempt-cli";
import type { RunAttemptOptions } from "../../packages/loopover-miner/lib/attempt-cli";
import type { AttemptCliResult, RunAttemptOptions } from "../../packages/loopover-miner/lib/attempt-cli";
import type { RuleFiredEvent, SignalStore } from "../../packages/loopover-engine/src/calibration/signal-tracking";
import * as minerSentryModule from "../../packages/loopover-miner/lib/sentry";
import * as liveIssueSnapshotModule from "../../packages/loopover-miner/lib/live-issue-snapshot";
Expand Down Expand Up @@ -143,6 +143,29 @@ afterEach(() => {
for (const root of roots.splice(0)) rmSync(root, { recursive: true, force: true });
});

describe("AttemptCliResult union (#9331)", () => {
it("includes the blocked_own_open_pr outcome with the runtime duplicateResult shape", () => {
// Compile-time guard: this object is the exact shape runAttempt builds for a crash-retry duplicate
// (#8808). Before the union member was added it only type-checked behind an `as` cast; removing the
// member makes this assignment a type error, so the .d.ts drift can't silently return.
const result: AttemptCliResult = {
outcome: "blocked_own_open_pr",
reason: "this miner already has an open PR for this issue",
repoFullName: "acme/widgets",
issueNumber: 7,
existingPullRequestNumber: 42,
minerLogin: "miner",
base: "main",
mode: "live",
attemptId: "attempt-1",
};
expect(result.outcome).toBe("blocked_own_open_pr");
if (result.outcome === "blocked_own_open_pr") {
expect(result.existingPullRequestNumber).toBe(42);
}
});
});

describe("parseAttemptArgs (#5132)", () => {
it("parses a full, valid argv", () => {
expect(
Expand Down