fix(gate): refresh PR files for merge readiness

[JSONbored]

Motivation

• The pre-gate PR-detail refresh only ran when slopGateMode or manifestPolicyGateMode were enabled, but mergeReadinessGateMode also consumes slop/file evidence so stale cached file lists could let a merge-readiness gate pass incorrectly.

Description

• Replace the explicit settings.slopGateMode !== "off" check with shouldCollectSlopEvidence(settings) so PR details are refreshed whenever slop evidence is needed (including merge-readiness-only configs) while preserving manifest refresh behavior.
• Add test instrumentation in test/unit/queue.test.ts to assert that the PR files endpoint is hit during the slop-off + merge-readiness scenario and verify the refresh occurs.
• Files changed: src/queue/processors.ts and test/unit/queue.test.ts.

Testing

• Ran the targeted unit test with npm test -- --run test/unit/queue.test.ts -t "clears the persisted dashboard slop score" and it passed.
• Ran the project's typecheck with npm run typecheck (TS tsc --noEmit) and it succeeded.

---

Codex Task

[ghost]

Note

Gittensory Gate skipped

PR closed before full evaluation. No late first comment was created.

Signal	Result	Evidence	Action
Gate result	⚠️ Skipped	#925 is no longer open.	No action.

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[ghost]

gittensory · advisory review

Reviewed 2 changed file(s) — two independent AI reviewers.

Changed files: src/queue/processors.ts, test/unit/queue.test.ts

Suggested action: ✅ Safe to merge — both reviewers found no blocking issues.

Reviewer A · gpt-oss-120b — recommends ✅ merge
The PR replaces a direct settings check with a helper function shouldCollectSlopEvidence and adds a test to verify that PR file refresh is triggered, capturing the fetch call for /pulls/91/files.

Suggestions

• Confirm that shouldCollectSlopEvidence is imported in processors.ts to avoid a compile error.
• Consider adding a complementary test case where the condition is false to ensure no unnecessary file fetch occurs.
• If shouldCollectSlopEvidence adds extra gating logic, document the intended behavior change for future maintainers.

Worth double-checking

• If the helper function's logic differs from the original settings.slopGateMode !== "off" check, it could unintentionally skip required refreshes.
• Missing import of the helper could break the build.

Reviewer B · nemotron-3-120b-a12b — recommends ✅ merge
The PR modifies the condition for triggering PR file refreshes in the GitHub webhook processor, replacing a direct slopGateMode check with a shouldCollectSlopEvidence(settings) call. It also updates a unit test to verify the refresh occurs when expected. The change appears to be a targeted fix for merge readiness logic, and the test addition provides appropriate coverage for the new behavior.

Worth double-checking

• Verify that shouldCollectSlopEvidence(settings) correctly captures the intended slop gate activation logic (not visible in diff).
• Ensure the test modification doesn't inadvertently override existing test assertions in the same test block.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.60%. Comparing base (cf5cc6d) to head (126b7d1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #925   +/-   ##
=======================================
  Coverage   96.60%   96.60%           
=======================================
  Files         109      109           
  Lines       14894    14894           
  Branches     5383     5383           
=======================================
  Hits        14389    14389           
  Misses        104      104           
  Partials      401      401           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.